You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Piotr Zarzycki <pi...@gmail.com> on 2020/06/17 16:11:07 UTC
Proposition to wait 24h before merging PR to develop
Hi Guys,
I was thinking for a long time and I believe this is good time to do that.
I'm proposing for waiting 24h before merging PR to the repository for non
committer who is trying to add/change/fix something in Royale.
The reason for that is - More than one committer or PMC would be able to
potentially look into the code and eventually make some kind of comments or
not.
Thoughts ?
Thanks,
--
Piotr Zarzycki
Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*
Re: Proposition to wait 24h before merging PR to develop
Posted by Carlos Rovira <ca...@apache.org>.
Hi Piotr,
looks ok for me too. I had this somehow in my head...
El mié., 17 jun. 2020 a las 18:23, Yishay Weiss (<yi...@hotmail.com>)
escribió:
> Probably a good idea. I don’t know if it should be a rule but I would say
> it was best practice.
>
> From: Piotr Zarzycki<ma...@gmail.com>
> Sent: Wednesday, June 17, 2020 7:11 PM
> To: Apache Royale Development<ma...@royale.apache.org>
> Subject: Proposition to wait 24h before merging PR to develop
>
> Hi Guys,
>
> I was thinking for a long time and I believe this is good time to do that.
>
> I'm proposing for waiting 24h before merging PR to the repository for non
> committer who is trying to add/change/fix something in Royale.
>
> The reason for that is - More than one committer or PMC would be able to
> potentially look into the code and eventually make some kind of comments or
> not.
>
> Thoughts ?
>
> Thanks,
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> <https://www.patreon.com/piotrzarzycki>*
>
>
--
Carlos Rovira
http://about.me/carlosrovira
RE: Proposition to wait 24h before merging PR to develop
Posted by Yishay Weiss <yi...@hotmail.com>.
Probably a good idea. I don’t know if it should be a rule but I would say it was best practice.
From: Piotr Zarzycki<ma...@gmail.com>
Sent: Wednesday, June 17, 2020 7:11 PM
To: Apache Royale Development<ma...@royale.apache.org>
Subject: Proposition to wait 24h before merging PR to develop
Hi Guys,
I was thinking for a long time and I believe this is good time to do that.
I'm proposing for waiting 24h before merging PR to the repository for non
committer who is trying to add/change/fix something in Royale.
The reason for that is - More than one committer or PMC would be able to
potentially look into the code and eventually make some kind of comments or
not.
Thoughts ?
Thanks,
--
Piotr Zarzycki
Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*