[GitHub] [hive] zabetak commented on a diff in pull request #4644: HIVE-27642 Add missing dependency to StartMiniHS2Cluster with Postgres

["zabetak (via GitHub)" <gi...@apache.org>]

zabetak commented on code in PR #4644:
URL: https://github.com/apache/hive/pull/4644#discussion_r1310268819


##########
itests/hive-unit/pom.xml:
##########
@@ -489,6 +489,10 @@
       <version>${htmlunit.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.postgresql</groupId>
+      <artifactId>postgresql</artifactId>

Review Comment:
   Either mark the dependency as optional or put it under test scope. Optional would keep things more uniform with the rest of the project but pick whatever you prefer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org