[GitHub] [hudi] danny0405 commented on a diff in pull request #8599: [MINOR] Ensure metrics prefix does not contain any dot.

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8599:
URL: https://github.com/apache/hudi/pull/8599#discussion_r1181158282


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2175,7 +2175,8 @@ public boolean getPushGatewayRandomJobNameSuffix() {
   }
 
   public String getMetricReporterMetricsNamePrefix() {
-    return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX);
+    // Metrics prefixes should not have a dot as this is usually a separator
+    return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX).replaceAll("\\.", "_");

Review Comment:
   Can we just report the invalid format and throws exception ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org