You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2026/03/16 09:51:06 UTC

[PR] workflow: enhance feature trigger handling in generate-e2e-sql-matrix.sh for improved matrix generation [shardingsphere]

sandynz opened a new pull request, #38460:
URL: https://github.com/apache/shardingsphere/pull/38460

   Related to  #38270.
   
   Changes proposed in this pull request:
     - workflow: enhance feature trigger handling in generate-e2e-sql-matrix.sh for improved matrix generation
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] workflow: enhance feature trigger handling in generate-e2e-sql-matrix.sh for improved matrix generation [shardingsphere]

Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz merged PR #38460:
URL: https://github.com/apache/shardingsphere/pull/38460


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] workflow: enhance feature trigger handling in generate-e2e-sql-matrix.sh for improved matrix generation [shardingsphere]

Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on PR #38460:
URL: https://github.com/apache/shardingsphere/pull/38460#issuecomment-4066469351

   Expectation: when any feature is changed, then other 3 dimensions (adapters, modes, databases) test cases.
   e.g. feature_sharding + adapter_jdbc.
   
   Test with bash script:
   ```bash
   ./generate-e2e-sql-matrix.sh '{"adapter_proxy":"false","adapter_jdbc":"true","mode_standalone":"false","mode_cluster":"false","mode_core":"false","database_mysql":"false","database_postgresql":"false","feature_sharding":"true","feature_encrypt":"false","feature_readwrite_splitting":"false","feature_shadow":"false","feature_mask":"false","feature_broadcast":"false","feature_distsql":"false","feature_sql_federation":"false","core_infra":"false","test_framework":"false","pom_changes":"false"}'
   ```
   
   Previous behavior: test `dimensions adapters=["jdbc"] modes=["Standalone","Cluster"] databases=["MySQL","PostgreSQL"]`
   ```
   ::notice::At least one relevant filter is true, will generate jobs based on dimensions and scenarios
   ::notice::filters any_base_change=false
   ::notice::dimensions adapters=["jdbc"] modes=["Standalone","Cluster"] databases=["MySQL","PostgreSQL"]
   ::notice::smoke-matrix count=10
   ::notice::full-matrix reason=feature-triggered, scenarios: ["db","tbl","dbtbl_with_readwrite_splitting","dbtbl_with_readwrite_splitting_and_encrypt","sharding_and_encrypt","sharding_and_shadow","sharding_encrypt_shadow","mask_sharding","mask_encrypt_sharding","db_tbl_sql_federation"]
   ::notice::full-matrix count=20
   ::notice::Generated 10 smoke jobs and 20 full jobs. Proxy image needed: false
   ```
   
   After changes: test `dimensions adapters=["proxy","jdbc"] modes=["Standalone","Cluster"] databases=["MySQL","PostgreSQL"]`
   ```
   ::notice::At least one relevant filter is true, will generate jobs based on dimensions and scenarios
   ::notice::Feature filters triggered, including all adapters, modes, and databases
   ::notice::any_base_change=false, any_feature_triggered=true, dimensions adapters=["proxy","jdbc"] modes=["Standalone","Cluster"] databases=["MySQL","PostgreSQL"]
   ::notice::smoke-matrix count=30
   ::notice::full-matrix reason=feature-triggered, scenarios: ["db","tbl","dbtbl_with_readwrite_splitting","dbtbl_with_readwrite_splitting_and_encrypt","sharding_and_encrypt","sharding_and_shadow","sharding_encrypt_shadow","mask_sharding","mask_encrypt_sharding","db_tbl_sql_federation"]
   ::notice::full-matrix count=60
   ::notice::Generated 30 smoke jobs and 60 full jobs. Proxy image needed: true
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org