You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "lupyuen (via GitHub)" <gi...@apache.org> on 2026/03/22 00:57:02 UTC

[PR] CI: Revert GitHub Actions for Docker, by hash [nuttx]

lupyuen opened a new pull request, #18575:
URL: https://github.com/apache/nuttx/pull/18575

   ## Summary
   
   __(Sorry to resubmit this PR. We must specify the GitHub Actions by Hash, not Version Number)__
   
   All CI Builds have been failing since 18 hours ago:
   - https://github.com/apache/nuttx/pull/18571#issuecomment-4104792750
   - https://github.com/apache/nuttx/actions/runs/23389990049
   
   > _The action docker/login-action@v4 is not allowed in apache/nuttx because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: 1Password/load-secrets-action@13f58eec611f8e5db52ec16247f58c508398f3e6, 1Password/load-secrets-action@8d0d610af187e78a2772c2d18d627f4c52d3fbfb, 1Password/load-secrets-action@dafbe7cb03502b260e2b2893c753c352eee545bf, AdoptOpenJDK/install-jdk@*, BobAnkh/auto-generate-changelog@*, DavidAnson/markdownlint-cli2-action@07035fd053f7be764496c0f8d8f9f41f98305101, DavidAnson/markdownlint-cli2-action@30a0e04f1870d58f8d717450cc6134995f993c63, EnricoMi/publish-unit-test-result-action@*, JamesIves/github-pages-deploy-action@4a3abc783e1a24aeb44c16e869ad83caf6b4cc23, JamesIves/github-pages-deploy-action@d92aa235d04922e8f08b40ce78cc5442fcfbfa2f, Jimver/cuda-toolkit@6008063726ffe3309d1b22e413d9e88fed91a2f2, Jimver/cuda-toolkit@b6fc3a9f3f15256d9d94ffe1254f9c5a2565cde6, JustinBeckwith/linkinator-action@af984b9f30f6
 3e796..._
   
   That's because ASF Infrastructure Team has mandated that we use the Hash Versions of GitHub Actions for Docker, stated below:
   - https://github.com/apache/infrastructure-actions/blob/main/actions.yml
   - Which generates: https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml
   - Due to: https://github.com/apache/infrastructure-actions/pull/547
   
   ```yaml
   docker/build-push-action:
     10e90e3645eae34f1e60eeb005ba3a3d33f178e8:
       tag: v6.19.2
   docker/login-action:
     c94ce9fb468520275223c153574b00df6fe4bcc9:
       tag: v3.7.0
   docker/metadata-action:
     c299e40c65443455700f0fdfc63efafe5b349051:
       tag: v5.10.0
   docker/setup-buildx-action:
     8d2750c68a42422c14e847fe6c8ac0403b4cbd6f:
       tag: v3.12.0
   ```
   
   This PR reverts our GitHub Actions for Docker to the hash versions stated above.
   
   ## Impact
   
   All CI Builds will now be started correctly.
   
   ## Testing
   
   We tested the updated GitHub Actions for Docker in our own NuttX Repo. The CI Build runs successfully:
   - https://github.com/lupyuen14/nuttx/actions/runs/23392418389
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CI: Revert GitHub Actions for Docker, by hash [nuttx]

Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #18575:
URL: https://github.com/apache/nuttx/pull/18575#issuecomment-4105152057

   I also had this idea once to verify master history against injected changes. This may come handy :-P


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CI: Revert GitHub Actions for Docker, by hash [nuttx]

Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #18575:
URL: https://github.com/apache/nuttx/pull/18575#issuecomment-4105150903

   Yup, saw that too, better safe than sorry :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CI: Revert GitHub Actions for Docker, by hash [nuttx]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #18575:
URL: https://github.com/apache/nuttx/pull/18575#issuecomment-4105145706

   Yep the ASF Policy Change is due to the Trivy Security Incident. Yesterday somehow I failed to understand the meaning of the exact words when I read this broadcast email (maybe `actions` should have been stated explicitly as `GitHub Actions`): https://news.apache.org/foundation/entry/initial-report-on-trivy-security-incident
   
   > _ASF Infra and ASF Security agreed to disable all previously allowed “verified creator” actions while the incident is being investigated <br><br> This may cause build failures, and require projects request newly-failed actions be added via the Infra GHA approval process: [github.com/apache/infrastructure-actions?tab=readme-ov-file#adding-a-new-version-to-the-allow-list](https://github.com/apache/infrastructure-actions?tab=readme-ov-file#adding-a-new-version-to-the-allow-list)_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CI: Revert GitHub Actions for Docker, by hash [nuttx]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #18575:
URL: https://github.com/apache/nuttx/pull/18575#issuecomment-4105077483

   @simbit18 FYI we need to update `docker/login-action` before June 2026, but after ASF has approved the new version (sigh): https://github.com/apache/nuttx/actions/runs/23392538906
   
   > [Linux (risc-v-01)](https://github.com/apache/nuttx/actions/runs/23392538906/job/68049769353#step:29:2)
   Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CI: Revert GitHub Actions for Docker, by hash [nuttx]

Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #18575:
URL: https://github.com/apache/nuttx/pull/18575#issuecomment-4105064846

   Yeah because c94ce9fb468520275223c153574b00df6fe4bcc9 is far more readable than v3.7.0 and also confirms it's a release :D :D 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CI: Revert GitHub Actions for Docker, by hash [nuttx]

Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 merged PR #18575:
URL: https://github.com/apache/nuttx/pull/18575


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org