You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Robert Kanter <rk...@cloudera.com> on 2015/05/04 23:23:26 UTC
Re: Review Request 33624: OOZIE-1993 Rerun fails during join in
certain condition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33624/#review82445
-----------------------------------------------------------
Ship it!
LGTM
- Robert Kanter
On April 30, 2015, 7:14 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33624/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 7:14 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1993
> https://issues.apache.org/jira/browse/OOZIE-1993
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> The issue was with picking up new execution path during re-runs. This will also address the issue in OOZIE-1879.
> Changes:
> 1. SignalXCommand to pick up the new execution path
> 2. Removed actionEndTimes comparison
> 3. Aligned else ifs in LiteWorkflowInstance.signal(). No logic changes
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6289158
> core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 6138278
> core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java bccac51
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 0e99ae2
> core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java d661d08
> core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java ba5b6b1
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 919c95a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 706cc2a
>
> Diff: https://reviews.apache.org/r/33624/diff/
>
>
> Testing
> -------
>
> end to end test for the example workflow in the jira - with failures at different nodes
>
>
> Thanks,
>
> Shwetha GS
>
>