You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/07/28 18:18:33 UTC
[GitHub] [pinot] walterddr opened a new pull request, #11208: [multistage] support the rest of the agg functions currently implementable
walterddr opened a new pull request, #11208:
URL: https://github.com/apache/pinot/pull/11208
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #11208: [multistage] support the rest of the agg functions currently implementable
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #11208:
URL: https://github.com/apache/pinot/pull/11208#discussion_r1278062898
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java:
##########
@@ -86,23 +87,32 @@ public enum AggregationFunctionType {
DISTINCTCOUNTHLL("distinctCountHLL", ImmutableList.of("DISTINCT_COUNT_HLL"), SqlKind.OTHER_FUNCTION,
SqlFunctionCategory.USER_DEFINED_FUNCTION, OperandTypes.ANY, ReturnTypes.BIGINT,
ReturnTypes.explicit(SqlTypeName.OTHER)),
- DISTINCTCOUNTRAWHLL("distinctCountRawHLL"),
- DISTINCTCOUNTSMARTHLL("distinctCountSmartHLL"),
+ DISTINCTCOUNTRAWHLL("distinctCountRawHLL", ImmutableList.of("DISTINCT_COUNT_RAW_HLL"), SqlKind.OTHER_FUNCTION,
+ SqlFunctionCategory.USER_DEFINED_FUNCTION,
+ OperandTypes.family(ImmutableList.of(SqlTypeFamily.ANY, SqlTypeFamily.INTEGER), ordinal -> ordinal > 0),
+ ReturnTypes.VARCHAR_2000, ReturnTypes.explicit(SqlTypeName.OTHER)),
+ DISTINCTCOUNTSMARTHLL("distinctCountSmartHLL", ImmutableList.of("DISTINCT_COUNT_SMART_HLL"), SqlKind.OTHER_FUNCTION,
Review Comment:
test needed for optional 2nd argument about HLL parameter string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11208: [multistage] support the rest of the agg functions currently implementable
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #11208:
URL: https://github.com/apache/pinot/pull/11208#discussion_r1280262676
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/LiteralHintUtils.java:
##########
@@ -46,13 +46,13 @@ public static String literalMapToHintString(Map<Pair<Integer, Integer>, RexExpre
e.getValue().getDataType().name(), e.getValue().getValue()));
}
// semi-colon is used to separate between encoded literals
- return "{" + StringUtils.join(literalStrings, ";") + "}";
+ return "{" + StringUtils.join(literalStrings, ";:;") + "}";
Review Comment:
where is this `;:;` used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #11208: [multistage] support the rest of the agg functions currently implementable
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #11208:
URL: https://github.com/apache/pinot/pull/11208#discussion_r1278062621
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java:
##########
@@ -86,23 +87,32 @@ public enum AggregationFunctionType {
DISTINCTCOUNTHLL("distinctCountHLL", ImmutableList.of("DISTINCT_COUNT_HLL"), SqlKind.OTHER_FUNCTION,
SqlFunctionCategory.USER_DEFINED_FUNCTION, OperandTypes.ANY, ReturnTypes.BIGINT,
ReturnTypes.explicit(SqlTypeName.OTHER)),
- DISTINCTCOUNTRAWHLL("distinctCountRawHLL"),
- DISTINCTCOUNTSMARTHLL("distinctCountSmartHLL"),
+ DISTINCTCOUNTRAWHLL("distinctCountRawHLL", ImmutableList.of("DISTINCT_COUNT_RAW_HLL"), SqlKind.OTHER_FUNCTION,
Review Comment:
test needed for optional 2nd argument about HLL log2m size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #11208: [multistage] support the rest of the agg functions currently implementable
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #11208:
URL: https://github.com/apache/pinot/pull/11208#discussion_r1278063300
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java:
##########
@@ -138,17 +148,23 @@ public enum AggregationFunctionType {
FOURTHMOMENT("fourthMoment"),
// DataSketches Tuple Sketch support
- DISTINCTCOUNTTUPLESKETCH("distinctCountTupleSketch"),
+ DISTINCTCOUNTTUPLESKETCH("distinctCountTupleSketch", null,
Review Comment:
this is not supported yet. should removed and move the TODO above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11208: [multistage] support the rest of the agg functions currently implementable
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11208:
URL: https://github.com/apache/pinot/pull/11208#issuecomment-1656189833
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11208](https://app.codecov.io/gh/apache/pinot/pull/11208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bb54a29) into [master](https://app.codecov.io/gh/apache/pinot/commit/35328c0f123337338a128145cbaf8e2bbf2b4be0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (35328c0) will **increase** coverage by `0.00%`.
> Report is 2 commits behind head on master.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #11208 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2225 2171 -54
Lines 119268 116811 -2457
Branches 18036 17747 -289
=========================================
Hits 137 137
+ Misses 119111 116654 -2457
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `0.11% <0.00%> (-0.01%)` | :arrow_down: |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...che/pinot/segment/spi/AggregationFunctionType.java](https://app.codecov.io/gh/apache/pinot/pull/11208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL0FnZ3JlZ2F0aW9uRnVuY3Rpb25UeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [69 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11208/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #11208: [multistage] support the rest of the agg functions currently implementable
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #11208:
URL: https://github.com/apache/pinot/pull/11208#discussion_r1280699265
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/LiteralHintUtils.java:
##########
@@ -46,13 +46,13 @@ public static String literalMapToHintString(Map<Pair<Integer, Integer>, RexExpre
e.getValue().getDataType().name(), e.getValue().getValue()));
}
// semi-colon is used to separate between encoded literals
- return "{" + StringUtils.join(literalStrings, ";") + "}";
+ return "{" + StringUtils.join(literalStrings, ";:;") + "}";
Review Comment:
the problem is b/c in some agg literals it allows stringify parameter type with `;` as the separator. this conflicts with my usage of `;` which indicates the "next literal hint".
Thus i used another 3-character splitter `;:;` to indicate hint-literal boundaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr merged pull request #11208: [multistage] support the rest of the agg functions currently implementable
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr merged PR #11208:
URL: https://github.com/apache/pinot/pull/11208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org