You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/12/25 16:22:00 UTC
[GitHub] [drill] vvysotskyi opened a new pull request #1942: Update
README.md with information on how to configure env for building site and
update .gitignore to ignore files left after checkout from developing
branches
vvysotskyi opened a new pull request #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] vvysotskyi commented on a change in pull request #1942:
Update README.md with information on how to configure env for building site
and update .gitignore to ignore files left after checkout from developing
branches
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#discussion_r362864137
##########
File path: README.md
##########
@@ -89,9 +104,9 @@ The updates should then be live: <http://drill.apache.org>.
The documentation pages are under `_docs`. Most files, in the YAML front matter, have three important parameters:
-* title: - This is the title of the page enclosed in quotation marks. Each page must have a *unique* title
-* date: - This field is needed for Jekyll to write a last-modified date. Initially, leave this field blank.
-* parent - This is the title of the page's parent page. It should be empty for top-level sections/guides, and be identical to the title attribute of another page in all other cases.
+* `title:` - This is the title of the page enclosed in quotation marks. Each page must have a *unique* title
+* `date:` - This field is needed for Jekyll to write a last-modified date. Initially, leave this field blank.
+* `parent:` - This is the title of the page's parent page. It should be empty for top-level sections/guides, and be identical to the title attribute of another page in all other cases.
Review comment:
Good point! Moved this section above `# Developing and Previewing the Website`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] paul-rogers commented on a change in pull request #1942:
Update README.md with information on how to configure env for building site
and update .gitignore to ignore files left after checkout from developing
branches
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on a change in pull request #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#discussion_r361892611
##########
File path: js/script.js
##########
@@ -1,109 +1,109 @@
----
----
-var reelPointer = null;
-$(document).ready(function(e) {
-
- $(".aLeft").click(function() {
- moveReel("prev");
- });
- $(".aRight").click(function() {
- moveReel("next");
- });
-
- if ($("#header .scroller .item").length == 1) {
-
- } else {
-
- $("#header .dots, .aLeft, .aRight").css({ display: 'block' });
- $("#header .scroller .item").each(function(i) {
- $("#header .dots").append("<div class='dot'></div>");
- $("#header .dots .dot").eq(i).click(function() {
- var index = $(this).prevAll(".dot").length;
- moveReel(index);
- });
- });
-
- reelPointer = setTimeout(function() { moveReel(1); },5000);
- }
-
- $("#menu ul li").each(function(index, element) {
- if ($(this).find("ul").length) {
- $(this).addClass("parent");
- }
- });
-
- $("#header .dots .dot:eq(0)").addClass("sel");
-
- resized();
-
- $(window).scroll(onScroll);
-
- var pathname = window.location.pathname;
- var pathSlashesReplaced = pathname.replace(/\//g, " ");
- var pathSlashesReplacedNoFirstDash = pathSlashesReplaced.replace(" ","");
- var newClass = pathSlashesReplacedNoFirstDash.replace(/(\.[\s\S]+)/ig, "");
- $("body").addClass(newClass);
- if ( $("body").attr("class") == "")
- {
- $("body").addClass("class");
- }
-});
-
-var reel_currentIndex = 0;
-function resized() {
-
- var WW = parseInt($(window).width(),10);
- var IW = (WW < 999) ? 999 : WW;
- var IH = parseInt($("#header .scroller .item").css("height"),10);
- var IN = $("#header .scroller .item").length;
-
- $("#header .scroller").css({ width: (IN * IW)+"px", marginLeft: -(reel_currentIndex * IW)+"px" });
- $("#header .scroller .item").css({ width: IW+"px" });
-
-
- $("#header .scroller .item").each(function(i) {
- var th = parseInt($(this).find(".tc").height(),10);
- var d = IH - th + 25;
- $(this).find(".tc").css({ top: Math.round(d/2)+"px" });
- });
-
- if (WW < 999) $("#menu").addClass("r");
- else $("#menu").removeClass("r");
-
- onScroll();
-
-}
-
-function moveReel(direction) {
-
- if (reelPointer) clearTimeout(reelPointer);
-
- var IN = $("#header .scroller .item").length;
- var IW = $("#header .scroller .item").width();
- if (direction == "next") reel_currentIndex++;
- else if (direction == "prev") reel_currentIndex--;
- else reel_currentIndex = direction;
-
- if (reel_currentIndex >= IN) reel_currentIndex = 0;
- if (reel_currentIndex < 0) reel_currentIndex = IN-1;
-
- $("#header .dots .dot").removeClass("sel");
- $("#header .dots .dot").eq(reel_currentIndex).addClass("sel");
-
- $("#header .scroller").stop(false,true,false).animate({ marginLeft: -(reel_currentIndex * IW)+"px" }, 1000, "easeOutQuart");
-
- reelPointer = setTimeout(function() { moveReel(1); },5000);
-
-}
-
-function onScroll() {
- var ST = document.body.scrollTop || document.documentElement.scrollTop;
- //if ($("#menu.r").length) {
- // $("#menu.r").css({ top: ST+"px" });
- //} else {
- // $("#menu").css({ top: "0px" });
- //}
-
- if (ST > 400) $("#subhead").addClass("show");
- else $("#subhead").removeClass("show");
-}
+---
+---
Review comment:
Why does Git think these lines changed? They look the same to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] vvysotskyi commented on a change in pull request #1942:
Update README.md with information on how to configure env for building site
and update .gitignore to ignore files left after checkout from developing
branches
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#discussion_r362863906
##########
File path: README.md
##########
@@ -13,60 +27,60 @@ Note that you can skip the first two commands (and only run `jekyll serve`) if y
## One Time Setup for Last-Modified-Date
-To automatically add the last-modified-on date, a one-time local setup is required:
-
-1. In your cloned directory of Drill, in drill/.git/hooks, create a file named pre-commit (no extension) that contains this script:
-
- #!/bin/sh
- # Contents of .git/hooks/pre-commit
-
- git diff --cached --name-status | grep "^M" | while read a b; do
- cat $b | sed "/---.*/,/---.*/s/^date:.*$/date: $(date -u "+%Y-%m-%d")/" > tmp
- mv tmp $b
- git add $b
- done
+To automatically add the `last-modified-on date`, a one-time local setup is required:
+1. In your cloned directory of Drill, in `drill/.git/hooks`, create a file named `pre-commit` (no extension) that contains this script:
+```
+#!/bin/sh
+# Contents of .git/hooks/pre-commit
+
+git diff --cached --name-status | grep "^M" | while read a b; do
+ cat $b | sed "/---.*/,/---.*/s/^date:.*$/date: $(date -u "+%Y-%m-%d")/" > tmp
+ mv tmp $b
+ git add $b
+done
+```
2. Make the file executable.
-
- chmod +x pre-commit
-
-On any page you create, in addition to the title: and parent:, you now need to add date: to the front matter of any file you create. For example:
-
- ---
- title: "Configuring Multitenant Resources"
- parent: "Configuring a Multitenant Cluster"
- date:
- ---
-
+```
+chmod +x pre-commit
+```
+On any page you create, in addition to the title, and `parent:`, you now need to add `date:` to the front matter of any file you create. For example:
Review comment:
Thanks, removed redundant any.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] vvysotskyi merged pull request #1942: Update README.md with
information on how to configure env for building site and update .gitignore
to ignore files left after checkout from developing branches
Posted by GitBox <gi...@apache.org>.
vvysotskyi merged pull request #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva commented on issue #1942: Update README.md
with information on how to configure env for building site and update
.gitignore to ignore files left after checkout from developing branches
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on issue #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#issuecomment-569082379
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva edited a comment on issue #1942: Update
README.md with information on how to configure env for building site and
update .gitignore to ignore files left after checkout from developing
branches
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva edited a comment on issue #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#issuecomment-571104897
Looks good, I think this can be merged.
@paul-rogers any objections?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] vvysotskyi commented on a change in pull request #1942:
Update README.md with information on how to configure env for building site
and update .gitignore to ignore files left after checkout from developing
branches
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#discussion_r361326256
##########
File path: README.md
##########
@@ -1,5 +1,17 @@
The Apache Drill website is built using [Jekyll](http://jekyllrb.com/).
+# Configuring env
+1. Install `ruby`
+2. Install `bundler` and `jekyll` `v2.5.2`:
Review comment:
Thanks, good point, added this note after this list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva commented on a change in pull request
#1942: Update README.md with information on how to configure env for
building site and update .gitignore to ignore files left after checkout
from developing branches
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on a change in pull request #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#discussion_r361325725
##########
File path: README.md
##########
@@ -1,5 +1,17 @@
The Apache Drill website is built using [Jekyll](http://jekyllrb.com/).
+# Configuring env
+1. Install `ruby`
+2. Install `bundler` and `jekyll` `v2.5.2`:
Review comment:
If we need specific version, please make an explicit note about that, warning that others versions won't work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva commented on issue #1942: Update README.md
with information on how to configure env for building site and update
.gitignore to ignore files left after checkout from developing branches
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on issue #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#issuecomment-571104897
Looks good, I think this can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] paul-rogers commented on a change in pull request #1942:
Update README.md with information on how to configure env for building site
and update .gitignore to ignore files left after checkout from developing
branches
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on a change in pull request #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#discussion_r361892310
##########
File path: README.md
##########
@@ -13,60 +27,60 @@ Note that you can skip the first two commands (and only run `jekyll serve`) if y
## One Time Setup for Last-Modified-Date
-To automatically add the last-modified-on date, a one-time local setup is required:
-
-1. In your cloned directory of Drill, in drill/.git/hooks, create a file named pre-commit (no extension) that contains this script:
-
- #!/bin/sh
- # Contents of .git/hooks/pre-commit
-
- git diff --cached --name-status | grep "^M" | while read a b; do
- cat $b | sed "/---.*/,/---.*/s/^date:.*$/date: $(date -u "+%Y-%m-%d")/" > tmp
- mv tmp $b
- git add $b
- done
+To automatically add the `last-modified-on date`, a one-time local setup is required:
+1. In your cloned directory of Drill, in `drill/.git/hooks`, create a file named `pre-commit` (no extension) that contains this script:
+```
+#!/bin/sh
+# Contents of .git/hooks/pre-commit
+
+git diff --cached --name-status | grep "^M" | while read a b; do
+ cat $b | sed "/---.*/,/---.*/s/^date:.*$/date: $(date -u "+%Y-%m-%d")/" > tmp
+ mv tmp $b
+ git add $b
+done
+```
2. Make the file executable.
-
- chmod +x pre-commit
-
-On any page you create, in addition to the title: and parent:, you now need to add date: to the front matter of any file you create. For example:
-
- ---
- title: "Configuring Multitenant Resources"
- parent: "Configuring a Multitenant Cluster"
- date:
- ---
-
+```
+chmod +x pre-commit
+```
+On any page you create, in addition to the title, and `parent:`, you now need to add `date:` to the front matter of any file you create. For example:
Review comment:
A bit redundant: "On any page you create...of any file you create."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] paul-rogers commented on a change in pull request #1942:
Update README.md with information on how to configure env for building site
and update .gitignore to ignore files left after checkout from developing
branches
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on a change in pull request #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#discussion_r361892520
##########
File path: README.md
##########
@@ -89,9 +104,9 @@ The updates should then be live: <http://drill.apache.org>.
The documentation pages are under `_docs`. Most files, in the YAML front matter, have three important parameters:
-* title: - This is the title of the page enclosed in quotation marks. Each page must have a *unique* title
-* date: - This field is needed for Jekyll to write a last-modified date. Initially, leave this field blank.
-* parent - This is the title of the page's parent page. It should be empty for top-level sections/guides, and be identical to the title attribute of another page in all other cases.
+* `title:` - This is the title of the page enclosed in quotation marks. Each page must have a *unique* title
+* `date:` - This field is needed for Jekyll to write a last-modified date. Initially, leave this field blank.
+* `parent:` - This is the title of the page's parent page. It should be empty for top-level sections/guides, and be identical to the title attribute of another page in all other cases.
Review comment:
Does it make sense to move the build stuff after this intro? I wondered what "title:" and so on were above. Then, when I get here, I now learn what they are. Would be great to reverse the order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] vvysotskyi commented on a change in pull request #1942:
Update README.md with information on how to configure env for building site
and update .gitignore to ignore files left after checkout from developing
branches
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #1942: Update README.md with information on how to configure env for building site and update .gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#discussion_r362865504
##########
File path: js/script.js
##########
@@ -1,109 +1,109 @@
----
----
-var reelPointer = null;
-$(document).ready(function(e) {
-
- $(".aLeft").click(function() {
- moveReel("prev");
- });
- $(".aRight").click(function() {
- moveReel("next");
- });
-
- if ($("#header .scroller .item").length == 1) {
-
- } else {
-
- $("#header .dots, .aLeft, .aRight").css({ display: 'block' });
- $("#header .scroller .item").each(function(i) {
- $("#header .dots").append("<div class='dot'></div>");
- $("#header .dots .dot").eq(i).click(function() {
- var index = $(this).prevAll(".dot").length;
- moveReel(index);
- });
- });
-
- reelPointer = setTimeout(function() { moveReel(1); },5000);
- }
-
- $("#menu ul li").each(function(index, element) {
- if ($(this).find("ul").length) {
- $(this).addClass("parent");
- }
- });
-
- $("#header .dots .dot:eq(0)").addClass("sel");
-
- resized();
-
- $(window).scroll(onScroll);
-
- var pathname = window.location.pathname;
- var pathSlashesReplaced = pathname.replace(/\//g, " ");
- var pathSlashesReplacedNoFirstDash = pathSlashesReplaced.replace(" ","");
- var newClass = pathSlashesReplacedNoFirstDash.replace(/(\.[\s\S]+)/ig, "");
- $("body").addClass(newClass);
- if ( $("body").attr("class") == "")
- {
- $("body").addClass("class");
- }
-});
-
-var reel_currentIndex = 0;
-function resized() {
-
- var WW = parseInt($(window).width(),10);
- var IW = (WW < 999) ? 999 : WW;
- var IH = parseInt($("#header .scroller .item").css("height"),10);
- var IN = $("#header .scroller .item").length;
-
- $("#header .scroller").css({ width: (IN * IW)+"px", marginLeft: -(reel_currentIndex * IW)+"px" });
- $("#header .scroller .item").css({ width: IW+"px" });
-
-
- $("#header .scroller .item").each(function(i) {
- var th = parseInt($(this).find(".tc").height(),10);
- var d = IH - th + 25;
- $(this).find(".tc").css({ top: Math.round(d/2)+"px" });
- });
-
- if (WW < 999) $("#menu").addClass("r");
- else $("#menu").removeClass("r");
-
- onScroll();
-
-}
-
-function moveReel(direction) {
-
- if (reelPointer) clearTimeout(reelPointer);
-
- var IN = $("#header .scroller .item").length;
- var IW = $("#header .scroller .item").width();
- if (direction == "next") reel_currentIndex++;
- else if (direction == "prev") reel_currentIndex--;
- else reel_currentIndex = direction;
-
- if (reel_currentIndex >= IN) reel_currentIndex = 0;
- if (reel_currentIndex < 0) reel_currentIndex = IN-1;
-
- $("#header .dots .dot").removeClass("sel");
- $("#header .dots .dot").eq(reel_currentIndex).addClass("sel");
-
- $("#header .scroller").stop(false,true,false).animate({ marginLeft: -(reel_currentIndex * IW)+"px" }, 1000, "easeOutQuart");
-
- reelPointer = setTimeout(function() { moveReel(1); },5000);
-
-}
-
-function onScroll() {
- var ST = document.body.scrollTop || document.documentElement.scrollTop;
- //if ($("#menu.r").length) {
- // $("#menu.r").css({ top: ST+"px" });
- //} else {
- // $("#menu").css({ top: "0px" });
- //}
-
- if (ST > 400) $("#subhead").addClass("show");
- else $("#subhead").removeClass("show");
-}
+---
+---
Review comment:
This file was with CRLF line endings, but exactly the same file in https://github.com/apache/drill-site is committed with LF line endings (perhaps due to git warnings it wasn't committed there), so I made LF line endings there also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services