You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Gary D. Gregory (Jira)" <ji...@apache.org> on 2023/03/24 13:03:00 UTC

[jira] [Resolved] (VFS-833) Make constructor FileSystemOptions(Map) public

     [ https://issues.apache.org/jira/browse/VFS-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory resolved VFS-833.
---------------------------------
    Fix Version/s: 2.10.0
       Resolution: Fixed

In git master and the snapshot repository.

> Make constructor FileSystemOptions(Map) public
> ----------------------------------------------
>
>                 Key: VFS-833
>                 URL: https://issues.apache.org/jira/browse/VFS-833
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.9.0
>            Reporter: Kannan Ramamoorthy
>            Priority: Major
>             Fix For: 2.10.0
>
>
> *Problem:*
> The map `org.apache.commons.vfs2.FileSystemOptions#options` is TreeMap. The datastructure is  not thread-safe and resulting in situations like [this|https://ivoanjo.me/blog/2018/07/21/writing-to-a-java-treemap-concurrently-can-lead-to-an-infinite-loop-during-reads/]  when used in multithreaded environments.
> *Workaround:*
> As a workaround, we have to synchronize the `FileSystemOptions` in all the places of the code. 
> *Solution:*
>  *  If there is no issue, the constructor `
> protected FileSystemOptions(Map<FileSystemOptionKey, Object> options)` can be made public, so that users will have an option to pass a synchronized map when they have to. * Or, wrap the `TreeMap` instance with `java.util.Collections#synchronizedMap`, ensuring thread safety at the core.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)