You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "vineet semwal (Commented) (JIRA)" <ji...@apache.org> on 2012/04/14 10:51:29 UTC

[jira] [Commented] (WICKET-1175) IDataProvider-Overflow with size()

    [ https://issues.apache.org/jira/browse/WICKET-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254058#comment-13254058 ] 

vineet semwal commented on WICKET-1175:
---------------------------------------

this change will cause  a lot of trouble in migration ,jpa/hibernate still expects int for setfirstresult and setmaxresult ,i think this change wasnt even  necessary but since its already done ..i think IdataProvider#iterator should be changed to expect ints for first and maximum idataprovider#size() can still return long ,the logic is its totally impractical to think some one will iterate over the capability of int but yes a developer can still retrieve long Idataprovider#size() instead of executing a count query evertime.

thanks
                
> IDataProvider-Overflow with size()
> ----------------------------------
>
>                 Key: WICKET-1175
>                 URL: https://issues.apache.org/jira/browse/WICKET-1175
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: any
>            Reporter: Jan Kriesten
>            Assignee: Igor Vaynberg
>             Fix For: 6.0.0-beta1
>
>         Attachments: 0001-Loop-should-not-use-long.patch
>
>
> Hi,
> I get an Integer-overflow with my Dataprovider (yeah, there are a couple of entries in the database). Is there a reason why size() and iterator( first, count ) are limited to Integer?
> Regards, --- Jan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira