You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Wojtek Strzalka (JIRA)" <se...@james.apache.org> on 2011/01/23 00:30:43 UTC

[jira] Created: (IMAP-249) IMAP should not disconnect clients on bad command immediatelly

IMAP should not disconnect clients on bad command immediatelly
--------------------------------------------------------------

                 Key: IMAP-249
                 URL: https://issues.apache.org/jira/browse/IMAP-249
             Project: JAMES Imap
          Issue Type: Bug
          Components: Parser
    Affects Versions: 0.2-M1
            Reporter: Wojtek Strzalka
             Fix For: 0.2


When IMAP processor can not parse command immediately disconnects a client .

Unfortunately from time to time outlook sends bad commands to the server.
One of the examples is Outlook 2007 - when copying a message (drag & drop message with Ctrl) it sends an empty request to the server ( \r \n ).

There are 2 options I can think about:

a) handling only the case would require consuming '\r' '\n' characters before processing a tag
b) general change of error handling - here is what Courier-IMAP is doing:
     instead of sending bye & disconnecting, we could send NO, to avoid DoS 10 consequent errors are allowed, then say bye 




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Resolved: (IMAP-249) IMAP should not disconnect clients on bad command immediatelly

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/IMAP-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Norman Maurer resolved IMAP-249.
--------------------------------

    Resolution: Fixed

Fixed.. We now only disconnect after x invalid commands (default is disconnect on the 10th invalid command)

> IMAP should not disconnect clients on bad command immediatelly
> --------------------------------------------------------------
>
>                 Key: IMAP-249
>                 URL: https://issues.apache.org/jira/browse/IMAP-249
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Parser
>    Affects Versions: 0.2-M1
>            Reporter: Wojtek Strzalka
>            Assignee: Norman Maurer
>             Fix For: 0.2
>
>         Attachments: empty_request.pcap
>
>
> When IMAP processor can not parse command immediately disconnects a client .
> Unfortunately from time to time outlook sends bad commands to the server.
> One of the examples is Outlook 2007 - when copying a message (drag & drop message with Ctrl) it sends an empty request to the server ( \r \n ).
> There are 2 options I can think about:
> a) handling only the case would require consuming '\r' '\n' characters before processing a tag
> b) general change of error handling - here is what Courier-IMAP is doing:
>      instead of sending bye & disconnecting, we could send NO, to avoid DoS 10 consequent errors are allowed, then say bye 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Assigned: (IMAP-249) IMAP should not disconnect clients on bad command immediatelly

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/IMAP-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Norman Maurer reassigned IMAP-249:
----------------------------------

    Assignee: Norman Maurer

> IMAP should not disconnect clients on bad command immediatelly
> --------------------------------------------------------------
>
>                 Key: IMAP-249
>                 URL: https://issues.apache.org/jira/browse/IMAP-249
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Parser
>    Affects Versions: 0.2-M1
>            Reporter: Wojtek Strzalka
>            Assignee: Norman Maurer
>             Fix For: 0.2
>
>         Attachments: empty_request.pcap
>
>
> When IMAP processor can not parse command immediately disconnects a client .
> Unfortunately from time to time outlook sends bad commands to the server.
> One of the examples is Outlook 2007 - when copying a message (drag & drop message with Ctrl) it sends an empty request to the server ( \r \n ).
> There are 2 options I can think about:
> a) handling only the case would require consuming '\r' '\n' characters before processing a tag
> b) general change of error handling - here is what Courier-IMAP is doing:
>      instead of sending bye & disconnecting, we could send NO, to avoid DoS 10 consequent errors are allowed, then say bye 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (IMAP-249) IMAP should not disconnect clients on bad command immediatelly

Posted by "Wojtek Strzalka (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/IMAP-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wojtek Strzalka updated IMAP-249:
---------------------------------

    Attachment: empty_request.pcap

sample record from session with Outlook 2007 - it's multi threaded but you can see there broken request and the following BYE response

> IMAP should not disconnect clients on bad command immediatelly
> --------------------------------------------------------------
>
>                 Key: IMAP-249
>                 URL: https://issues.apache.org/jira/browse/IMAP-249
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Parser
>    Affects Versions: 0.2-M1
>            Reporter: Wojtek Strzalka
>             Fix For: 0.2
>
>         Attachments: empty_request.pcap
>
>
> When IMAP processor can not parse command immediately disconnects a client .
> Unfortunately from time to time outlook sends bad commands to the server.
> One of the examples is Outlook 2007 - when copying a message (drag & drop message with Ctrl) it sends an empty request to the server ( \r \n ).
> There are 2 options I can think about:
> a) handling only the case would require consuming '\r' '\n' characters before processing a tag
> b) general change of error handling - here is what Courier-IMAP is doing:
>      instead of sending bye & disconnecting, we could send NO, to avoid DoS 10 consequent errors are allowed, then say bye 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org