You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/09 06:29:03 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #11210: fix: show TIME COLUMN options in dashboard
graceguo-supercat opened a new pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210
### SUMMARY
Fix UI issue for TIME COLUMN dropdown list.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**BEFORE:**
<img width="1218" alt="Screen Shot 2020-10-08 at 11 22 47 PM" src="https://user-images.githubusercontent.com/27990562/95550528-e88dad00-09bd-11eb-8b98-ae3547f7a831.png">
**AFTER:**
<img width="1200" alt="Screen Shot 2020-10-08 at 11 22 06 PM" src="https://user-images.githubusercontent.com/27990562/95550518-e4618f80-09bd-11eb-844b-41dd207da3dd.png">
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `1.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 59.95% -1.43%
==========================================
Files 828 392 -436
Lines 39145 24544 -14601
Branches 3589 0 -3589
==========================================
- Hits 24028 14716 -9312
+ Misses 14937 9828 -5109
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `59.95% <ø> (-0.88%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `94.77% <0.00%> (-5.23%)` | :arrow_down: |
| ... and [451 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...734cd69](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-707329708
Can we add a test case if it's not too much work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `0.59%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 60.78% -0.60%
==========================================
Files 828 394 -434
Lines 39145 24716 -14429
Branches 3589 0 -3589
==========================================
- Hits 24028 15024 -9004
+ Misses 14937 9692 -5245
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.78% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.87% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.15% <0.00%> (-0.06%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <0.00%> (ø)` | |
| ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `0.76%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 60.61% -0.77%
==========================================
Files 828 394 -434
Lines 39145 24716 -14429
Branches 3589 0 -3589
==========================================
- Hits 24028 14982 -9046
+ Misses 14937 9734 -5203
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.61% <ø> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.87% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.60% <0.00%> (-0.10%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.15% <0.00%> (-0.06%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...1fd8813](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
+ Coverage 61.38% 61.47% +0.08%
==========================================
Files 828 832 +4
Lines 39145 39397 +252
Branches 3589 3593 +4
==========================================
+ Hits 24028 24218 +190
- Misses 14937 14998 +61
- Partials 180 181 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <100.00%> (+0.32%)` | :arrow_up: |
| #python | `60.78% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <100.00%> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `56.79% <100.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.87% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.15% <0.00%> (-0.06%)` | :arrow_down: |
| ... and [889 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#discussion_r503654091
##########
File path: superset-frontend/spec/javascripts/explore/components/FilterBox_spec.jsx
##########
@@ -58,4 +59,30 @@ describe('FilterBox', () => {
inst.setState({ selectedValues: { name: 'James' } });
expect(inst.props.filtersChoices.name.length).toEqual(3);
});
+
+ it('should support granularity_sqla options', () => {
Review comment:
added a dumb unit test. Time range filter box will soon be replaced by dashboard component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **increase** coverage by `4.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
+ Coverage 61.38% 65.45% +4.06%
==========================================
Files 828 832 +4
Lines 39145 39400 +255
Branches 3589 3593 +4
==========================================
+ Hits 24028 25788 +1760
+ Misses 14937 13499 -1438
+ Partials 180 113 -67
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.21% <25.00%> (?)` | |
| #javascript | `62.62% <100.00%> (+0.32%)` | :arrow_up: |
| #python | `60.78% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <100.00%> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `60.49% <100.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.87% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.15% <0.00%> (-0.06%)` | :arrow_down: |
| ... and [889 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 61.05% -0.33%
==========================================
Files 828 832 +4
Lines 39145 39397 +252
Branches 3589 3593 +4
==========================================
+ Hits 24028 24054 +26
- Misses 14937 15162 +225
- Partials 180 181 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <100.00%> (+0.32%)` | :arrow_up: |
| #python | `60.12% <ø> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <100.00%> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `56.79% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-3.89%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| ... and [890 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `1.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 60.08% -1.30%
==========================================
Files 828 394 -434
Lines 39145 24705 -14440
Branches 3589 0 -3589
==========================================
- Hits 24028 14844 -9184
+ Misses 14937 9861 -5076
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.08% <ø> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-3.89%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.74% <0.00%> (-1.39%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| ... and [455 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...1fd8813](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **increase** coverage by `4.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
+ Coverage 61.38% 65.60% +4.22%
==========================================
Files 828 832 +4
Lines 39145 39400 +255
Branches 3589 3593 +4
==========================================
+ Hits 24028 25849 +1821
+ Misses 14937 13443 -1494
+ Partials 180 108 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.91% <25.00%> (?)` | |
| #javascript | `62.62% <100.00%> (+0.32%)` | :arrow_up: |
| #python | `60.78% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <100.00%> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `60.49% <100.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.87% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.15% <0.00%> (-0.06%)` | :arrow_down: |
| ... and [889 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `1.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 59.74% -1.64%
==========================================
Files 828 394 -434
Lines 39145 24705 -14440
Branches 3589 0 -3589
==========================================
- Hits 24028 14760 -9268
+ Misses 14937 9945 -4992
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `59.74% <ø> (-1.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [468 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...1fd8813](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `0.31%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 61.06% -0.32%
==========================================
Files 828 832 +4
Lines 39145 39386 +241
Branches 3589 3593 +4
==========================================
+ Hits 24028 24051 +23
- Misses 14937 15154 +217
- Partials 180 181 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <100.00%> (+0.32%)` | :arrow_up: |
| #python | `60.13% <ø> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <100.00%> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `56.79% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-3.89%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| ... and [894 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `0.76%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 60.61% -0.77%
==========================================
Files 828 394 -434
Lines 39145 24716 -14429
Branches 3589 0 -3589
==========================================
- Hits 24028 14981 -9047
+ Misses 14937 9735 -5202
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.61% <ø> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.87% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.60% <0.00%> (-0.10%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.15% <0.00%> (-0.06%)` | :arrow_down: |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...1fd8813](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `1.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 59.95% -1.43%
==========================================
Files 828 392 -436
Lines 39145 24544 -14601
Branches 3589 0 -3589
==========================================
- Hits 24028 14716 -9312
+ Misses 14937 9828 -5109
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `59.95% <ø> (-0.88%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `94.77% <0.00%> (-5.23%)` | :arrow_down: |
| ... and [451 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...734cd69](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `2.31%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 59.06% -2.32%
==========================================
Files 828 798 -30
Lines 39145 38121 -1024
Branches 3589 3390 -199
==========================================
- Hits 24028 22516 -1512
- Misses 14937 15423 +486
- Partials 180 182 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.88% <0.00%> (?)` | |
| #javascript | `?` | |
| #python | `60.78% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `15.85% <0.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.87% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.15% <0.00%> (-0.06%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| ... and [854 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 61.05% -0.33%
==========================================
Files 828 832 +4
Lines 39145 39386 +241
Branches 3589 3593 +4
==========================================
+ Hits 24028 24049 +21
- Misses 14937 15156 +219
- Partials 180 181 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <100.00%> (+0.32%)` | :arrow_up: |
| #python | `60.12% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <100.00%> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `56.79% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-3.89%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| ... and [896 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `1.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 60.12% -1.26%
==========================================
Files 828 394 -434
Lines 39145 24716 -14429
Branches 3589 0 -3589
==========================================
- Hits 24028 14860 -9168
+ Misses 14937 9856 -5081
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.12% <ø> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-3.89%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (-0.56%)` | :arrow_down: |
| ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...1fd8813](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `2.54%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 58.83% -2.55%
==========================================
Files 828 798 -30
Lines 39145 38121 -1024
Branches 3589 3390 -199
==========================================
- Hits 24028 22429 -1599
- Misses 14937 15502 +565
- Partials 180 190 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.24% <0.00%> (?)` | |
| #javascript | `?` | |
| #python | `60.78% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `15.85% <0.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.87% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.15% <0.00%> (-0.06%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
| ... and [854 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
- Coverage 61.38% 61.36% -0.02%
==========================================
Files 828 832 +4
Lines 39145 39397 +252
Branches 3589 3593 +4
==========================================
+ Hits 24028 24176 +148
- Misses 14937 15040 +103
- Partials 180 181 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <100.00%> (+0.32%)` | :arrow_up: |
| #python | `60.61% <ø> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <100.00%> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `56.79% <100.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.87% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.60% <0.00%> (-0.10%)` | :arrow_down: |
| ... and [885 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11210: fix: show TIME COLUMN options in dashboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11210:
URL: https://github.com/apache/incubator-superset/pull/11210#issuecomment-705999091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=h1) Report
> Merging [#11210](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5561b429f3dcf876ea8e13d839060dca7f5dfd04?el=desc) will **increase** coverage by `1.24%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11210 +/- ##
==========================================
+ Coverage 61.38% 62.62% +1.24%
==========================================
Files 828 438 -390
Lines 39145 14681 -24464
Branches 3589 3593 +4
==========================================
- Hits 24028 9194 -14834
+ Misses 14937 5306 -9631
- Partials 180 181 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <100.00%> (+0.32%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <100.00%> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `56.79% <100.00%> (ø)` | |
| [...t/superset-frontend/src/messageToasts/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvbWVzc2FnZVRvYXN0cy9jb25zdGFudHMuanM=) | | |
| [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBFcnJvck1lc3NhZ2VzRXh0cmEudHM=) | | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL01ldHJpY3NDb250cm9sLmpzeA==) | | |
| [superset/migrations/versions/e3970889f38e\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzk3MDg4OWYzOGVfLnB5) | | |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | | |
| [...superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9TZWxlY3Qvc3R5bGVzLnRzeA==) | | |
| [...t/superset-frontend/src/profile/components/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvcHJvZmlsZS9jb21wb25lbnRzL0FwcC50c3g=) | | |
| [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Qb3BvdmVyU2VjdGlvbi5qc3g=) | | |
| ... and [1258 more](https://codecov.io/gh/apache/incubator-superset/pull/11210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=footer). Last update [5561b42...6c7e059](https://codecov.io/gh/apache/incubator-superset/pull/11210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org