[jira] [Commented] (OPENJPA-2381) Update serp to 1.14.2

["Kevin Sutter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658513#comment-13658513 ] 

Kevin Sutter commented on OPENJPA-2381:
---------------------------------------

Version 1.14.2 of Serp is actually "trunk".  Trunk is the current snapshot for 1.14.2.  So, pulling in a new version of "Serp 1.14.2" is not as easy as it sounds, unfortunately.  This would require someone creating a new Serp release (not sure of the process) and then pulling it into the OpenJPA trunk.  Pulling in a new/updated dependency into an OpenJPA service stream can be dangerous.  In this case, maybe it could be considered a simple bug fix (moving from 1.14.1 to 1.14.2).  I just looked at the source and here's the simple change that is in 1.14.2 that corrects the issue:

    public Instruction getEnd() {
        if (_end != null)
            return _end;
        int idx = _target.getByteIndex() + _length;
        Instruction end = getCode().getInstruction(idx);
        if (end != null && (end.prev instanceof Instruction)) {  // updated
             return (Instruction) end.prev;                               // new
        }
        return getCode().getLastInstruction();
    }

                
> Update serp to 1.14.2
> ---------------------
>
>                 Key: OPENJPA-2381
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2381
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: Enhance
>    Affects Versions: 2.2.2
>            Reporter: Danny D'Amours
>            Priority: Minor
>             Fix For: 2.2.3
>
>
> There is a new version 1.14.2 of Serp that appears to fix OPENJPA-888 (https://issues.apache.org/jira/browse/OPENJPA-888).
> Would it be possible to update to 1.14.2 in OpenJPA?
> Serp 1.14.2 : http://serp.cvs.sourceforge.net/viewvc/serp/serp/
> Also: http://openjpa.apache.org/publishing-serp-to-maven-central-repository.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira