You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/16 21:06:19 UTC
[GitHub] [maven-doxia-sitetools] michael-o opened a new pull request, #64: [DOXIASITETOOLS-267] Upgrade to Doxia 2.0.0-M4
michael-o opened a new pull request, #64:
URL: https://github.com/apache/maven-doxia-sitetools/pull/64
This closes #64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on a diff in pull request #64: [DOXIASITETOOLS-267] Upgrade to Doxia 2.0.0-M4
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #64:
URL: https://github.com/apache/maven-doxia-sitetools/pull/64#discussion_r1027323823
##########
doxia-site-renderer/src/test/resources/site/fml/faq.fml:
##########
@@ -20,7 +20,7 @@ under the License.
<faqs xmlns="http://maven.apache.org/FML/1.0.1"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/FML/1.0.1 file:../../../../../../../doxia/doxia-modules/doxia-module-fml/src/main/resources/fml-1.0.1.xsd"
Review Comment:
No, it is not. Doxia bundles them now and the resource resolver will pick then up from classpath. See: https://github.com/apache/maven-doxia/pull/115/files#diff-262a682f07b45aeb2cacb62700410586a3e522010b21edfa3f7d213e62d2794bR701-R714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on a diff in pull request #64: [DOXIASITETOOLS-267] Upgrade to Doxia 2.0.0-M4
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #64:
URL: https://github.com/apache/maven-doxia-sitetools/pull/64#discussion_r1027324632
##########
doxia-site-renderer/src/test/resources/site/fml/faq.fml:
##########
@@ -20,7 +20,7 @@ under the License.
<faqs xmlns="http://maven.apache.org/FML/1.0.1"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/FML/1.0.1 file:../../../../../../../doxia/doxia-modules/doxia-module-fml/src/main/resources/fml-1.0.1.xsd"
Review Comment:
This also expects that Doxia Core is physically present to Sitetools which is not always the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] hboutemy commented on a diff in pull request #64: [DOXIASITETOOLS-267] Upgrade to Doxia 2.0.0-M4
Posted by GitBox <gi...@apache.org>.
hboutemy commented on code in PR #64:
URL: https://github.com/apache/maven-doxia-sitetools/pull/64#discussion_r1027324207
##########
doxia-site-renderer/src/test/resources/site/fml/faq.fml:
##########
@@ -20,7 +20,7 @@ under the License.
<faqs xmlns="http://maven.apache.org/FML/1.0.1"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/FML/1.0.1 file:../../../../../../../doxia/doxia-modules/doxia-module-fml/src/main/resources/fml-1.0.1.xsd"
Review Comment:
oh, great, then ok, wrong evaluation from me: this is a really nice improvement from Doxia 2.0.0-M4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on a diff in pull request #64: [DOXIASITETOOLS-267] Upgrade to Doxia 2.0.0-M4
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #64:
URL: https://github.com/apache/maven-doxia-sitetools/pull/64#discussion_r1027323853
##########
doxia-site-renderer/src/test/resources/site/fml/faq.fml:
##########
@@ -20,7 +20,7 @@ under the License.
<faqs xmlns="http://maven.apache.org/FML/1.0.1"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/FML/1.0.1 file:../../../../../../../doxia/doxia-modules/doxia-module-fml/src/main/resources/fml-1.0.1.xsd"
Review Comment:
https://issues.apache.org/jira/browse/DOXIA-669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] asfgit closed pull request #64: [DOXIASITETOOLS-267] Upgrade to Doxia 2.0.0-M4
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #64: [DOXIASITETOOLS-267] Upgrade to Doxia 2.0.0-M4
URL: https://github.com/apache/maven-doxia-sitetools/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] hboutemy commented on a diff in pull request #64: [DOXIASITETOOLS-267] Upgrade to Doxia 2.0.0-M4
Posted by GitBox <gi...@apache.org>.
hboutemy commented on code in PR #64:
URL: https://github.com/apache/maven-doxia-sitetools/pull/64#discussion_r1027323337
##########
doxia-site-renderer/src/test/resources/site/fml/faq.fml:
##########
@@ -20,7 +20,7 @@ under the License.
<faqs xmlns="http://maven.apache.org/FML/1.0.1"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/FML/1.0.1 file:../../../../../../../doxia/doxia-modules/doxia-module-fml/src/main/resources/fml-1.0.1.xsd"
Review Comment:
I'm not convinced removing xdoc-2.0.xsd and fml-1.0.1.xsd copies are a good idea: it adds a network dependency during build
at least this should be a separate issue: this is not about upgrading Doxia 2.0 M3 to M4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on a diff in pull request #64: [DOXIASITETOOLS-267] Upgrade to Doxia 2.0.0-M4
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #64:
URL: https://github.com/apache/maven-doxia-sitetools/pull/64#discussion_r1027323980
##########
doxia-site-renderer/src/test/resources/site/fml/faq.fml:
##########
@@ -20,7 +20,7 @@ under the License.
<faqs xmlns="http://maven.apache.org/FML/1.0.1"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/FML/1.0.1 file:../../../../../../../doxia/doxia-modules/doxia-module-fml/src/main/resources/fml-1.0.1.xsd"
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org