[jira] [Commented] (BEAM-1184) Add integration tests for ElasticsearchIO

["Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797685#comment-15797685 ] 

Jean-Baptiste Onofré commented on BEAM-1184:
--------------------------------------------

On other IOs (ReddisIO or RabbitMqIO for instance), I also have test with {{@Ignore}} as it's not possible to embed such resources with Java (Reddis is OS dependant, RabbitMQ uses Erlang for instance). I will implement tests using mock for these IOs.
However, as discussed on the mailing list, I really think it makes sense to have a dedicated module (itests for instance) containing all the itests. Those itests can requires resources (for instance a docker container for elasticsearch, another one with Reddis, another one with RabbitMQ, ...) and optionally schedule/starts those resources (using Kubernetes or Marathon for instance).

I think we can start the {{itest}} module gathering Elasticsearch, Reddis, RabbitMQ related tests and resources. Actually, I already start such module on a branch on my github, I will push and share with you.

> Add integration tests for ElasticsearchIO
> -----------------------------------------
>
>                 Key: BEAM-1184
>                 URL: https://issues.apache.org/jira/browse/BEAM-1184
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-java-extensions
>            Reporter: Stephen Sisk
>            Assignee: Etienne Chauchot
>
> In https://github.com/apache/incubator-beam/pull/1439#pullrequestreview, the original PR included a dockerfile and an integration test that ran against an ES instance in that dockerfile. 
> We are working on infrastructure to stand up docker containers for this kind of testing, but aren't quite ready for it, so we pulled the scripts, dockerfile+IT out of that PR. This issue tracks checking that work in once we can take advantage of it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)