You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/08/07 15:14:54 UTC

Review Request 61466: Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61466/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.


Bugs: MESOS-7853
    https://issues.apache.org/jira/browse/MESOS-7853


Repository: mesos


Description
-------

Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.


Diffs
-----

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp e46643434dc85d766bd549a037f36a89a6738678 


Diff: https://reviews.apache.org/r/61466/diff/1/


Testing
-------


Thanks,

Qian Zhang


Re: Review Request 61466: Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61466/#review182754
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 879 (patched)
<https://reviews.apache.org/r/61466/#comment258748>

    Could we follow the semantics in this file and use `containerid1`, `containerid2` etc.?



src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 934 (patched)
<https://reviews.apache.org/r/61466/#comment258749>

    ditto to sandboxPath1, sandboxPath2..


- Gilbert Song


On Aug. 7, 2017, 8:14 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61466/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2017, 8:14 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7853
>     https://issues.apache.org/jira/browse/MESOS-7853
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp e46643434dc85d766bd549a037f36a89a6738678 
> 
> 
> Diff: https://reviews.apache.org/r/61466/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 61466: Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61466/#review182314
-----------------------------------------------------------



Patch looks great!

Reviews applied: [61270, 61406, 61428, 61463, 61464, 61465, 61466]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On Aug. 7, 2017, 3:14 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61466/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2017, 3:14 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7853
>     https://issues.apache.org/jira/browse/MESOS-7853
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp e46643434dc85d766bd549a037f36a89a6738678 
> 
> 
> Diff: https://reviews.apache.org/r/61466/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 61466: Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61466/
-----------------------------------------------------------

(Updated Aug. 14, 2017, 10:05 a.m.)


Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.


Changes
-------

Addressed comments.


Bugs: MESOS-7853
    https://issues.apache.org/jira/browse/MESOS-7853


Repository: mesos


Description
-------

Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.


Diffs (updated)
-----

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp e46643434dc85d766bd549a037f36a89a6738678 


Diff: https://reviews.apache.org/r/61466/diff/2/

Changes: https://reviews.apache.org/r/61466/diff/1-2/


Testing
-------


Thanks,

Qian Zhang