You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2011/09/15 08:08:56 UTC

svn commit: r1170963 - in /james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty: SMTPResponseEncoder.java SMTPServer.java

Author: norman
Date: Thu Sep 15 06:08:55 2011
New Revision: 1170963

URL: http://svn.apache.org/viewvc?rev=1170963&view=rev
Log:
Use a static instance of SMTPResponseEncoder as the class is shareable

Modified:
    james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/SMTPResponseEncoder.java
    james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java

Modified: james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/SMTPResponseEncoder.java
URL: http://svn.apache.org/viewvc/james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/SMTPResponseEncoder.java?rev=1170963&r1=1170962&r2=1170963&view=diff
==============================================================================
--- james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/SMTPResponseEncoder.java (original)
+++ james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/SMTPResponseEncoder.java Thu Sep 15 06:08:55 2011
@@ -24,10 +24,12 @@ import java.util.List;
 
 import org.apache.james.protocols.impl.AbstractResponseEncoder;
 import org.apache.james.protocols.smtp.SMTPResponse;
+import org.jboss.netty.channel.ChannelHandler.Sharable;
 
 /**
  * {@link AbstractResponseEncoder} which encode {@link SMTPResponse} objects
  */
+@Sharable
 public class SMTPResponseEncoder extends AbstractResponseEncoder<SMTPResponse> {
 
     public SMTPResponseEncoder() {

Modified: james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java
URL: http://svn.apache.org/viewvc/james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java?rev=1170963&r1=1170962&r2=1170963&view=diff
==============================================================================
--- james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java (original)
+++ james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java Thu Sep 15 06:08:55 2011
@@ -85,6 +85,8 @@ public class SMTPServer extends Abstract
     private DNSService dns;
     private String authorizedAddresses;
 
+    private final static SMTPResponseEncoder SMTP_RESPONSE_ENCODER = new SMTPResponseEncoder();
+    
     @Resource(name = "dnsservice")
     public void setDNSService(DNSService dns) {
         this.dns = dns;
@@ -362,7 +364,7 @@ public class SMTPServer extends Abstract
 
     @Override
     protected OneToOneEncoder createEncoder() {
-        return new SMTPResponseEncoder();
+        return SMTP_RESPONSE_ENCODER;
     }
 
     @Override



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org