You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/09/23 06:47:37 UTC
[GitHub] [openwhisk] chetanmeh commented on issue #4638: Remove legacy view
code from subjects index.
chetanmeh commented on issue #4638: Remove legacy view code from subjects index.
URL: https://github.com/apache/openwhisk/pull/4638#issuecomment-533977897
This would need a change in `SubjectViewMapper`
```diff
Index: common/scala/src/main/scala/org/apache/openwhisk/core/database/cosmosdb/CosmosDBViewMapper.scala
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- common/scala/src/main/scala/org/apache/openwhisk/core/database/cosmosdb/CosmosDBViewMapper.scala (date 1568315768000)
+++ common/scala/src/main/scala/org/apache/openwhisk/core/database/cosmosdb/CosmosDBViewMapper.scala (date 1569220431853)
@@ -279,7 +279,7 @@
count: Boolean): SqlQuerySpec = {
require(startKey == endKey, s"startKey: $startKey and endKey: $endKey must be same for $ddoc/$view")
(ddoc, view) match {
- case ("subjects", "identities") =>
+ case (s, "identities") if s.startsWith("subjects") =>
queryForMatchingSubjectOrNamespace(ddoc, view, startKey, endKey, count)
case ("namespaceThrottlings", "blockedNamespaces") =>
queryForBlacklistedNamespace(count)
```
Some more changes would be needed to remove existing support (which was there as per the previous view) and would be done as part of #4639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services