You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/12 21:49:33 UTC

[GitHub] [tvm] junrushao commented on a diff in pull request #11639: [TIR][Meta-Schedule] Tuple-reduction scheduling support

junrushao commented on code in PR #11639:
URL: https://github.com/apache/tvm/pull/11639#discussion_r968962959


##########
tests/python/unittest/test_tir_transform_lower_cross_thread_reduction.py:
##########
@@ -44,7 +47,7 @@ def loop_split(a: T.handle, b: T.handle) -> None:
             with T.block("B"):
                 vi = T.axis.S(128, i)
                 vk = T.axis.R(128, ko * 32 + ki)
-                T.reads([B[vi], A[vi, vk]])
+                T.reads([A[vi, vk]])

Review Comment:
   Why are we removing `B[vi]` from `T.reads`? It's actually read, isn't it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org