You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/03 05:23:25 UTC

[GitHub] [hudi] KnightChess commented on a change in pull request #5215: [HUDI-3781] fix spark delete sql can not delete record

KnightChess commented on a change in pull request #5215:
URL: https://github.com/apache/hudi/pull/5215#discussion_r841162307



##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/DeleteHoodieTableCommand.scala
##########
@@ -65,7 +65,7 @@ case class DeleteHoodieTableCommand(deleteTable: DeleteFromTable) extends Hoodie
 
     assert(hoodieCatalogTable.primaryKeys.nonEmpty,
       s"There are no primary key defined in table $tableId, cannot execute delete operator")
-    withSparkConf(sparkSession, hoodieCatalogTable.catalogProperties) {
+    val globalConf = withSparkConf(sparkSession, hoodieCatalogTable.catalogProperties) {

Review comment:
       looks great




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org