You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "James Peach (JIRA)" <ji...@apache.org> on 2012/10/09 06:48:02 UTC
[jira] [Created] (TS-1513) SPDY plugin crashes on connection close
James Peach created TS-1513:
-------------------------------
Summary: SPDY plugin crashes on connection close
Key: TS-1513
URL: https://issues.apache.org/jira/browse/TS-1513
Project: Traffic Server
Issue Type: Bug
Components: Plugins
Reporter: James Peach
Assignee: James Peach
Following on from TS-1462,
Conan Wang added a comment - 26/Sep/12 21:47
About spdy test(on 3.2.x), request is not finished/closed normally after sending http header and body. I can see Chrome is hanging for a while (for seconds set in transaction_no_activity_timeout_in) before closing the connection(or session). When closing the connection, ATS will crash. (http://pastebin.com/kjAjkv3d)
If I disable keep-alive, ATS will crash immediately after sending the response. (http://pastebin.com/nBxWieiB)
Spdy request/response is done correctly. (http://pastebin.com/BRXzcJJr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1513) SPDY plugin crashes on connection
close
Posted by "Conan Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475596#comment-13475596 ]
Conan Wang commented on TS-1513:
--------------------------------
opened TS-1525
> SPDY plugin crashes on connection close
> ---------------------------------------
>
> Key: TS-1513
> URL: https://issues.apache.org/jira/browse/TS-1513
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: James Peach
> Assignee: James Peach
> Fix For: 3.3.2
>
>
> Following on from TS-1462,
> Conan Wang added a comment - 26/Sep/12 21:47
> About spdy test(on 3.2.x), request is not finished/closed normally after sending http header and body. I can see Chrome is hanging for a while (for seconds set in transaction_no_activity_timeout_in) before closing the connection(or session). When closing the connection, ATS will crash. (http://pastebin.com/kjAjkv3d)
> If I disable keep-alive, ATS will crash immediately after sending the response. (http://pastebin.com/nBxWieiB)
> Spdy request/response is done correctly. (http://pastebin.com/BRXzcJJr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-1513) SPDY plugin crashes on connection close
Posted by "James Peach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach resolved TS-1513.
-----------------------------
Resolution: Fixed
dc36d49eb3e240b3d8fd8b89ab178a7b1ec17d8b TS-1513: SPDY plugin crashes on connection close
Thanks for testing! Fixed the crash in this bug; let's open a new one for the SPDY connection issues.
> SPDY plugin crashes on connection close
> ---------------------------------------
>
> Key: TS-1513
> URL: https://issues.apache.org/jira/browse/TS-1513
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: James Peach
> Assignee: James Peach
> Fix For: 3.3.2
>
>
> Following on from TS-1462,
> Conan Wang added a comment - 26/Sep/12 21:47
> About spdy test(on 3.2.x), request is not finished/closed normally after sending http header and body. I can see Chrome is hanging for a while (for seconds set in transaction_no_activity_timeout_in) before closing the connection(or session). When closing the connection, ATS will crash. (http://pastebin.com/kjAjkv3d)
> If I disable keep-alive, ATS will crash immediately after sending the response. (http://pastebin.com/nBxWieiB)
> Spdy request/response is done correctly. (http://pastebin.com/BRXzcJJr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1513) SPDY plugin crashes on connection
close
Posted by "Conan Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473127#comment-13473127 ]
Conan Wang commented on TS-1513:
--------------------------------
crash on git master too.
PluginVC::do_io_close is called twice at one session which may lead the crash (ink_assert: closed == false). 'closed' will turn true only inside PluginVC::do_io_close.
observed with gdb, second produce the crash:
{code}
(gdb) bt
#0 0x0000000100070557 in PluginVC::do_io_close ()
#1 0x00000001000465d7 in TSVConnClose ()
#2 0x000000000078f9b8 in spdy_stream_io (contp=0x203c8b0, ev=TS_EVENT_VCONN_EOS, edata=0x205b730) at src/ts/stream.cc:232
#3 0x000000010003488e in INKContInternal::handle_event ()
#4 0x0000000100028467 in Continuation::handleEvent ()
#5 0x000000010006e510 in PluginVC::process_read_side ()
#6 0x000000010006d5a8 in PluginVC::main_handler ()
#7 0x0000000100028467 in Continuation::handleEvent ()
#8 0x00000001002a9059 in EThread::process_event ()
#9 0x00000001002a938b in EThread::execute ()
#10 0x000000010005de39 in main ()
{code}
{code}
(gdb) bt
#0 0x0000000100070557 in PluginVC::do_io_close ()
#1 0x00000001000465d7 in TSVConnClose ()
#2 0x000000000078feba in spdy_io_stream::close (this=0x44d0f0) at src/ts/stream.cc:329
#3 0x000000000078fa10 in spdy_stream_io (contp=0x203c8b0, ev=TS_EVENT_VCONN_EOS, edata=0x205b730) at src/ts/stream.cc:240
#4 0x000000010003488e in INKContInternal::handle_event ()
#5 0x0000000100028467 in Continuation::handleEvent ()
#6 0x000000010006e510 in PluginVC::process_read_side ()
#7 0x000000010006d5a8 in PluginVC::main_handler ()
#8 0x0000000100028467 in Continuation::handleEvent ()
#9 0x00000001002a9059 in EThread::process_event ()
#10 0x00000001002a938b in EThread::execute ()
#11 0x000000010005de39 in main ()
{code}
> SPDY plugin crashes on connection close
> ---------------------------------------
>
> Key: TS-1513
> URL: https://issues.apache.org/jira/browse/TS-1513
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: James Peach
> Assignee: James Peach
> Fix For: 3.3.2
>
>
> Following on from TS-1462,
> Conan Wang added a comment - 26/Sep/12 21:47
> About spdy test(on 3.2.x), request is not finished/closed normally after sending http header and body. I can see Chrome is hanging for a while (for seconds set in transaction_no_activity_timeout_in) before closing the connection(or session). When closing the connection, ATS will crash. (http://pastebin.com/kjAjkv3d)
> If I disable keep-alive, ATS will crash immediately after sending the response. (http://pastebin.com/nBxWieiB)
> Spdy request/response is done correctly. (http://pastebin.com/BRXzcJJr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1513) SPDY plugin crashes on connection
close
Posted by "Conan Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474096#comment-13474096 ]
Conan Wang commented on TS-1513:
--------------------------------
update: crash disappear if build without --enable-debug.. Your patch (http://apaste.info/ehfo) can avoid the crash as well (with --enable-debug).
More issue:
1. Single spdy page work fine. But if I reload the page in browser continuously and quickly, the request will hang. If the page have multiple spdy elements(e.g. images), the hang also occur easily when reloading.
2. Status line in response is malformed, chrome browser cannot recognize the 304 not modified, for example.
> SPDY plugin crashes on connection close
> ---------------------------------------
>
> Key: TS-1513
> URL: https://issues.apache.org/jira/browse/TS-1513
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: James Peach
> Assignee: James Peach
> Fix For: 3.3.2
>
>
> Following on from TS-1462,
> Conan Wang added a comment - 26/Sep/12 21:47
> About spdy test(on 3.2.x), request is not finished/closed normally after sending http header and body. I can see Chrome is hanging for a while (for seconds set in transaction_no_activity_timeout_in) before closing the connection(or session). When closing the connection, ATS will crash. (http://pastebin.com/kjAjkv3d)
> If I disable keep-alive, ATS will crash immediately after sending the response. (http://pastebin.com/nBxWieiB)
> Spdy request/response is done correctly. (http://pastebin.com/BRXzcJJr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1513) SPDY plugin crashes on connection close
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-1513:
------------------------------
Fix Version/s: 3.3.2
> SPDY plugin crashes on connection close
> ---------------------------------------
>
> Key: TS-1513
> URL: https://issues.apache.org/jira/browse/TS-1513
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: James Peach
> Assignee: James Peach
> Fix For: 3.3.2
>
>
> Following on from TS-1462,
> Conan Wang added a comment - 26/Sep/12 21:47
> About spdy test(on 3.2.x), request is not finished/closed normally after sending http header and body. I can see Chrome is hanging for a while (for seconds set in transaction_no_activity_timeout_in) before closing the connection(or session). When closing the connection, ATS will crash. (http://pastebin.com/kjAjkv3d)
> If I disable keep-alive, ATS will crash immediately after sending the response. (http://pastebin.com/nBxWieiB)
> Spdy request/response is done correctly. (http://pastebin.com/BRXzcJJr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira