Re: [PR] Fix parsing reference for nested fields [iceberg-python]

["Fokko (via GitHub)" <gi...@apache.org>]

Fokko commented on code in PR #965:
URL: https://github.com/apache/iceberg-python/pull/965#discussion_r1707383378


##########
pyiceberg/io/pyarrow.py:
##########
@@ -572,51 +572,54 @@ def _convert_scalar(value: Any, iceberg_type: IcebergType) -> pa.scalar:
 
 
 class _ConvertToArrowExpression(BoundBooleanExpressionVisitor[pc.Expression]):
+    def _flat_name_to_list(self, name: str) -> List[str]:
+        return name.split(".")

Review Comment:
   This is a risky route. I'd rather migrate to a `Tuple[str]` situation internally so we can actually support fields with `.`'s



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org