You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/21 21:03:43 UTC
[GitHub] [fineract] vorburger opened a new pull request #779: add link to Web UIs, Mobile App, and fineract.dev
vorburger opened a new pull request #779:
URL: https://github.com/apache/fineract/pull/779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #779: add link to Web UIs, Mobile App, and fineract.dev
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #779:
URL: https://github.com/apache/fineract/pull/779#issuecomment-619569433
Go ahead. @vorburger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #779: add link to Web UIs, Mobile App, and fineract.dev
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #779:
URL: https://github.com/apache/fineract/pull/779#issuecomment-619522806
Here is the problem: https://travis-ci.org/github/apache/fineract/builds/677887476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nikpawar89 commented on pull request #779: add link to Web UIs, Mobile App, and fineract.dev
Posted by GitBox <gi...@apache.org>.
nikpawar89 commented on pull request #779:
URL: https://github.com/apache/fineract/pull/779#issuecomment-619567353
@vorburger just thinking out loud- do we want to mention https://github.com/openMF/mifosx for pentaho reports related module? otherwise +1 from me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #779: add link to Web UIs, Mobile App, and fineract.dev
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #779:
URL: https://github.com/apache/fineract/pull/779#issuecomment-619518304
#783 ignores the failing test. I'm closing and re-opening to see if it passes.
@awasum do you want to review and Rebase and Merge this REVIEW change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #779: add link to Web UIs, Mobile App, and fineract.dev
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #779:
URL: https://github.com/apache/fineract/pull/779#issuecomment-619567681
> @vorburger just thinking out loud- do we want to mention https://github.com/openMF/mifosx for pentaho reports related module? otherwise +1 from me.
Hmm..Good one...But pentaho reports with current Fineract is even broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #779: add link to Web UIs, Mobile App, and fineract.dev
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #779:
URL: https://github.com/apache/fineract/pull/779#issuecomment-619522767
Seems there is a problem.
```
org.apache.fineract.integrationtests.RecurringDepositTest > testRecurringDepositAccountWithPrematureClosureTypeReinvest FAILED
java.lang.AssertionError at RecurringDepositTest.java:3048
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #779: add link to Web UIs, Mobile App, and fineract.dev
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #779:
URL: https://github.com/apache/fineract/pull/779#issuecomment-619565946
@nikpawar89 @xurror thanks for your interest and votes of support for the README change in #782.
How do you feel about this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #779: add link to Web UIs, Mobile App, and fineract.dev
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #779:
URL: https://github.com/apache/fineract/pull/779#issuecomment-619523173
#784
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #779: add link to Web UIs, Mobile App, and fineract.dev
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #779:
URL: https://github.com/apache/fineract/pull/779#issuecomment-619568744
> @vorburger just thinking out loud- do we want to mention https://github.com/openMF/mifosx for pentaho reports related module?
No, I'm actively against that, because I fear that could create a lot more confusion than answer anyone's question... that repo de facto is "dead", given that it hasn't been updated in 4 years, and IMHO we shouldn't refer to it anymore from Fineract's README (other than perhaps from a "Historical" section for archaeologists, if anyone would like to add something like that).
I do understand the (old) issue about Pentaho-based reports having been "lost" in the move to Apache. That is a problem I suspect someone will want to address somehow, someday (with a separate additional service, perhaps?), but this PR is not the place for that?
Anyway, strictly speaking, https://github.com/openMF/mifosx is course not the "pentaho reports related module", but a (now very old) predecessor version of the same code that is in this repo. (You cannot "use" that "module" with fineract, just like that.)
> otherwise +1 from me.
Ok, then based on that +1 and @xurror approval, let's merge this, if OK for you as-is @awasum ?
PS: Build failed again due to another FINERACT-885 - I'll deal with that separately, let's not hold this up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org