You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/03 10:13:35 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #4747: cks: fix token TTL, set it to never expire
shwstppr opened a new pull request #4747:
URL: https://github.com/apache/cloudstack/pull/4747
### Description
Fixes #4742
kubeadm init is called with `--token-ttl 0`
This will allow the token to remain valid forever.
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Checked token details after k8s cluster deployment;
```
Container Linux by CoreOS stable (2303.3.0)
Update Strategy: No Reboots
core@t2-master ~ $ sudo kubadm token list
sudo: kubadm: command not found
core@t2-master ~ $ sudo kubeadm token list
TOKEN TTL EXPIRES USAGES DESCRIPTION EXTRA GROUPS
00dec2.178dc8478dbecfc5 <forever> <never> authentication,signing The default bootstrap token generated by 'kubeadm init'. system:bootstrappers:kubeadm:default-node-token
ul9g7i.jl1ehlghm8apx634 1h 2021-03-03T12:03:15Z <none> Proxy for managing TTL for the kubeadm-certs secret <none>
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4747: cks: fix token TTL, set it to never expire
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4747:
URL: https://github.com/apache/cloudstack/pull/4747#issuecomment-790453958
Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 49
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4747: cks: fix token TTL, set it to never expire
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4747:
URL: https://github.com/apache/cloudstack/pull/4747#issuecomment-790182066
<b>Trillian test result (tid-3646)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32954 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4747-t3646-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 190.60 | test_internal_lb.py
test_01_migrate_VM_and_root_volume | `Error` | 60.69 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 48.77 | test_vm_life_cycle.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4747: cks: fix token TTL, set it to never expire
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4747:
URL: https://github.com/apache/cloudstack/pull/4747#issuecomment-789759219
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4747: cks: fix token TTL, set it to never expire
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4747:
URL: https://github.com/apache/cloudstack/pull/4747#issuecomment-789601513
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4747: cks: fix token TTL, set it to never expire
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4747:
URL: https://github.com/apache/cloudstack/pull/4747#issuecomment-789601128
Explicitly set the base branch to 4.14 in case 4.14.2 is released in future.
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4747: cks: fix token TTL, set it to never expire
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4747:
URL: https://github.com/apache/cloudstack/pull/4747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4747: cks: fix token TTL, set it to never expire
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4747:
URL: https://github.com/apache/cloudstack/pull/4747#issuecomment-789621571
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2860
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4747: cks: fix token TTL, set it to never expire
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4747:
URL: https://github.com/apache/cloudstack/pull/4747#issuecomment-789760194
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org