You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/24 10:42:58 UTC

[GitHub] [rocketmq] fulln commented on a diff in pull request #4366: [ISSUE #4365] acl PlainPermissionManager key file paths set to same

fulln commented on code in PR #4366:
URL: https://github.com/apache/rocketmq/pull/4366#discussion_r880348550


##########
common/src/main/java/org/apache/rocketmq/common/MixAll.java:
##########
@@ -87,6 +87,8 @@ public class MixAll {
     public static final String REPLY_MESSAGE_FLAG = "reply";
     public static final String LMQ_PREFIX = "%LMQ%";
     public static final String MULTI_DISPATCH_QUEUE_SPLITTER = ",";
+    public static final String MULTI_SEPARATE = "//";
+    public static final String SEPARATE_DOT = "/.";

Review Comment:
   1. i can only judge the last 2 char 
   2.  what you describe  is when acl config file path is illegal( contain “//” or “ /.” ) ,throw AclException directly?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org