You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2021/10/08 16:15:14 UTC

svn commit: r1894032 - /poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java

Author: fanningpj
Date: Fri Oct  8 16:15:14 2021
New Revision: 1894032

URL: http://svn.apache.org/viewvc?rev=1894032&view=rev
Log:
[bug-65326] accessExternalSchema is usually not accepted on TransformerFactory

Modified:
    poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java

Modified: poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java?rev=1894032&r1=1894031&r2=1894032&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java Fri Oct  8 16:15:14 2021
@@ -223,7 +223,7 @@ public final class XMLHelper {
         trySet(factory::setFeature, FEATURE_SECURE_PROCESSING, true);
         trySet(factory::setAttribute, ACCESS_EXTERNAL_DTD, "");
         trySet(factory::setAttribute, ACCESS_EXTERNAL_STYLESHEET, "");
-        trySet(factory::setAttribute, ACCESS_EXTERNAL_SCHEMA, "");
+        quietSet(factory::setAttribute, ACCESS_EXTERNAL_SCHEMA, "");
         return factory;
     }
 
@@ -291,6 +291,16 @@ public final class XMLHelper {
         }
         return false;
     }
+
+    private static boolean quietSet(SecurityProperty property, String name, Object value) {
+        try {
+            property.accept(name, value);
+            return true;
+        } catch (Exception|Error e) {
+            // ok to ignore
+        }
+        return false;
+    }
 
     private static void logThrowable(Throwable t, String message, String name) {
         if (System.currentTimeMillis() > lastLog + TimeUnit.MINUTES.toMillis(5)) {



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org