You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "Maxwell-Guo (via GitHub)" <gi...@apache.org> on 2025/03/04 04:50:44 UTC
Re: [PR] CASSANDRA-13428 - provide keystore_password_file and truststore_passw… [cassandra]
Maxwell-Guo commented on code in PR #3908:
URL: https://github.com/apache/cassandra/pull/3908#discussion_r1978608485
##########
conf/cassandra_latest.yaml:
##########
@@ -1718,8 +1739,17 @@ client_encryption_options:
# accepted_protocols: [TLSv1.2,TLSv1.3,TLSv1.1]
# keystore: conf/cassandra_ssl.keystore
# keystore_password: cassandra
+ # Optional configuration to specify password for keystore in a separate file
+ # When keystore_password and keystore_password_file both are specified, the keystore_password will take precedence
+ # The password in the file should be on the first line
+ # keystore_password_file: conf/keystore_passwordfile.txt
# truststore: conf/cassandra_ssl.truststore
# truststore_password: cassandra
+ # Optional configuration to specify password for truststore in a separate file
+ # When truststore_password and truststore_password_file both are specified, the truststore_password will take precedence
+ # The password in the file should be on the first line
+ # truststore_password_file: conf/truststore_passwordfile.txt
+
Review Comment:
I think we can remove this line , and we can do this on commit.
##########
conf/cassandra.yaml:
##########
@@ -1844,8 +1865,17 @@ client_encryption_options:
# accepted_protocols: [TLSv1.2,TLSv1.3,TLSv1.1]
# keystore: conf/cassandra_ssl.keystore
# keystore_password: cassandra
+ # Optional configuration to specify password for keystore in a separate file
+ # When keystore_password and keystore_password_file both are specified, the keystore_password will take precedence
+ # The password in the file should be on the first line
+ # keystore_password_file: conf/keystore_passwordfile.txt
# truststore: conf/cassandra_ssl.truststore
# truststore_password: cassandra
+ # Optional configuration to specify password for truststore in a separate file
+ # When truststore_password and truststore_password_file both are specified, the truststore_password will take precedence
+ # The password in the file should be on the first line
+ # truststore_password_file: conf/truststore_passwordfile.txt
+
Review Comment:
I think we can remove this line , and we can do this on commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org