[GitHub] [hadoop] xiaoyuyao commented on issue #903: HDDS-1490. Support configurable container placement policy through 'o…

[GitBox <gi...@apache.org>]

xiaoyuyao commented on issue #903: HDDS-1490. Support configurable container placement policy through 'o…
URL: https://github.com/apache/hadoop/pull/903#issuecomment-499196069
 
 
   bq. Cannot mock/spy class org.apache.hadoop.ozone.om.OzoneManager
   Mockito cannot mock/spy because :final class
   
   I think this is related to the change in the pom.xml where we only add the topology related xml files to testResources explicitly. In this case, I think we will need to add the mokito-extensions from the test/resources as well explicitly. This is need to surpress the warning above. 
   
        <testResource>
          <directory>${basedir}/src/test/resources</directory>
        </testResource>
   
   Also, please fix the checkstyle issue in the next commit. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org