You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "shangxinli (via GitHub)" <gi...@apache.org> on 2025/12/31 17:16:04 UTC

[PR] refactor: use std::make_unique instead of raw new in ReaderProperties [iceberg-cpp]

shangxinli opened a new pull request, #474:
URL: https://github.com/apache/iceberg-cpp/pull/474

   Replace raw new with std::make_unique for better exception safety and modern C++ best practices in ReaderProperties::default_properties() and ReaderProperties::FromMap().
   
   Using std::make_unique provides:
   - Better exception safety (no leak if constructor throws)
   - More concise and readable code
   - Consistent with modern C++ guidelines


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] refactor: use std::make_unique instead of raw new in ReaderProperties [iceberg-cpp]

Posted by "shangxinli (via GitHub)" <gi...@apache.org>.
shangxinli closed pull request #474: refactor: use std::make_unique instead of raw new in ReaderProperties
URL: https://github.com/apache/iceberg-cpp/pull/474


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org