You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by je...@ci.trafficserver.apache.org on 2016/04/18 10:11:45 UTC
Build failed in Jenkins: clang-format #720

See <https://ci.trafficserver.apache.org/job/clang-format/720/changes>

Changes:

[briang] TS-4312 Add config to strictly parse URL according to RFC 3986. This

------------------------------------------
[...truncated 1646 lines...]
./proxy/Main.h
./proxy/ICPlog.h
./proxy/StatPages.cc
./proxy/ProtocolProbeSessionAccept.cc
./proxy/logcat.cc
./proxy/AbstractBuffer.cc
./proxy/ProxyClientTransaction.h
./proxy/TestDNS.cc
./proxy/Plugin.h
./proxy/congest/Congestion.h
./proxy/congest/CongestionTest.cc
./proxy/congest/CongestionStats.h
./proxy/congest/CongestionDB.h
./proxy/congest/CongestionStats.cc
./proxy/congest/CongestionDB.cc
./proxy/congest/Congestion.cc
./proxy/congest/MT_hashtable.h
./proxy/TestPreProc.cc
./proxy/ProtocolProbeSessionAccept.h
./proxy/FetchSM.h
./proxy/Crash.cc
./proxy/ParentRoundRobin.h
./proxy/InkAPIInternal.h
./proxy/Show.h
./proxy/spdy/SpdyDefs.h
./proxy/spdy/SpdySessionAccept.h
./proxy/spdy/SpdySessionAccept.cc
./proxy/spdy/SpdyClientSession.h
./proxy/spdy/SpdyClientSession.cc
./proxy/spdy/SpdyCallbacks.cc
./proxy/spdy/SpdyCommon.h
./proxy/spdy/SpdyCommon.cc
./proxy/spdy/SpdyCallbacks.h
./proxy/PluginVC.h
./proxy/RegressionSM.cc
./proxy/FetchSM.cc
./proxy/TestClusterHash.cc
./proxy/ParentRoundRobin.cc
./proxy/TimeTrace.h
./proxy/ParentSelection.h
./proxy/InkIOCoreAPI.cc
./proxy/Transform.h
./proxy/InkAPI.cc
./proxy/RegressionSM.h
./proxy/ProxyClientSession.cc
./proxy/CoreUtils.cc
./proxy/shared/Error.h
./proxy/shared/UglyLogStubs.cc
./proxy/shared/DiagsConfig.h
./proxy/shared/InkXml.cc
./proxy/shared/DiagsConfig.cc
./proxy/shared/InkXml.h
./proxy/shared/Error.cc
./proxy/UnixCompletionUtil.h
./proxy/ICPConfig.cc
./proxy/IPAllow.h
./proxy/TestProxy.cc
./proxy/ParentSelection.cc
./proxy/HttpTransStats.h
./proxy/PluginVC.cc
./proxy/EventName.h
./proxy/TestSimpleProxy.cc
./proxy/ConfigParse.h
./proxy/Prefetch.h
./proxy/http/TestUrl.cc
./proxy/http/HttpBodyFactory.h
./proxy/http/Http1ClientSession.h
./proxy/http/Http1ClientTransaction.cc
./proxy/http/Http1ClientTransaction.h
./proxy/http/HttpTransactHeaders.cc
./proxy/http/HttpTransact.cc
./proxy/http/HttpPages.h
./proxy/http/HttpProxyServerMain.cc
./proxy/http/HttpServerSession.h
./proxy/http/HttpPages.cc
./proxy/http/HttpTunnel.cc
./proxy/http/TestHttpTransact.cc
./proxy/http/test_socket_close.cc
./proxy/http/HttpSM.cc
./proxy/http/HttpConfig.h
./proxy/http/HttpUpdateTester.cc
./proxy/http/HttpSessionManager.h
./proxy/http/HttpProxyAPIEnums.h
./proxy/http/HttpCacheSM.cc
./proxy/http/HttpTransactHeaders.h
./proxy/http/HttpTransactCache.h
./proxy/http/HttpTransactCache.cc
./proxy/http/HttpProxyServerMain.h
./proxy/http/HttpTunnel.h
./proxy/http/HttpUpdateSM.h
./proxy/http/HttpDebugNames.h
./proxy/http/HttpBodyFactory.cc
./proxy/http/HttpTransact.h
./proxy/http/Http1ClientSession.cc
./proxy/http/HttpConfig.cc
./proxy/http/HttpServerSession.cc
./proxy/http/HttpUpdateSM.cc
./proxy/http/HttpConnectionCount.h
./proxy/http/testheaders.cc
./proxy/http/HttpConnectionCount.cc
./proxy/http/HttpSessionAccept.h
./proxy/http/HttpDebugNames.cc
./proxy/http/RegressionHttpTransact.cc
./proxy/http/HttpSessionAccept.cc
./proxy/http/remap/RemapConfig.cc
./proxy/http/remap/UrlMapping.h
./proxy/http/remap/RemapProcessor.h
./proxy/http/remap/UrlRewrite.h
./proxy/http/remap/RemapPlugins.cc
./proxy/http/remap/UrlMapping.cc
./proxy/http/remap/AclFiltering.h
./proxy/http/remap/RemapPluginInfo.h
./proxy/http/remap/UrlMappingPathIndex.h
./proxy/http/remap/RemapProcessor.cc
./proxy/http/remap/RemapPlugins.h
./proxy/http/remap/UrlRewrite.cc
./proxy/http/remap/RemapPluginInfo.cc
./proxy/http/remap/RemapConfig.h
./proxy/http/remap/AclFiltering.cc
./proxy/http/remap/UrlMappingPathIndex.cc
./proxy/http/HttpSessionManager.cc
./proxy/http/HttpCacheSM.h
./proxy/http/HttpSM.h
./proxy/TestRegex.cc
./proxy/IPAllow.cc
./proxy/ICPProcessor.cc
./proxy/ReverseProxy.cc
./proxy/ControlMatcher.h
./proxy/SocksProxy.cc
./proxy/UDPAPITest.h
./proxy/UserNameCacheTest.h
./proxy/ICP.h
./proxy/ProxyClientSession.h
./proxy/ParentConsistentHash.h
./proxy/CacheControl.h
./proxy/InkAPITestTool.cc
./proxy/ControlBase.cc
./proxy/http2/Http2DebugNames.cc
./proxy/http2/Http2ClientSession.cc
./proxy/http2/RegressionHPACK.cc
./proxy/http2/Http2ConnectionState.h
./proxy/http2/test_Huffmancode.cc
./proxy/http2/Http2SessionAccept.h
./proxy/http2/Http2DebugNames.h
./proxy/http2/HuffmanCodec.h
./proxy/http2/Http2ConnectionState.cc
./proxy/http2/HTTP2.cc
./proxy/http2/Http2Stream.h
./proxy/http2/Http2ClientSession.h
./proxy/http2/HPACK.h
./proxy/http2/HTTP2.h
./proxy/http2/HuffmanCodec.cc
./proxy/http2/Http2SessionAccept.cc
./proxy/http2/Http2Stream.cc
./proxy/http2/HPACK.cc
./proxy/Main.cc
./proxy/UDPAPIClientTest.cc
./proxy/Plugin.cc
./proxy/TestClock.cc
./proxy/UDPAPIClientTest.h
./proxy/ICPProcessor.h
./proxy/InkAPITest.cc
./proxy/EventName.cc
./proxy/CompletionUtil.h
./proxy/ReverseProxy.h
./proxy/Prefetch.cc
./proxy/TestPreProc.h
./proxy/StatPages.h
./proxy/CacheControl.cc
./proxy/ICP.cc
./proxy/ControlBase.h
./proxy/hdrs/URL.cc
./proxy/hdrs/MIME.h
./proxy/hdrs/HdrTest.h
./proxy/hdrs/test_mime.cc
./proxy/hdrs/HdrTest.cc
./proxy/hdrs/HTTP.cc
./proxy/hdrs/HttpCompat.cc
./proxy/hdrs/HdrUtils.h
./proxy/hdrs/HdrUtils.cc
./proxy/hdrs/HdrToken.cc
./proxy/hdrs/HdrTSOnly.cc
./proxy/hdrs/HdrHeap.cc
./proxy/hdrs/test_urlhash.cc
./proxy/hdrs/HTTP.h
./proxy/hdrs/load_http_hdr.cc
./proxy/hdrs/URL.h
./proxy/hdrs/MIME.cc
./proxy/hdrs/HdrHeap.h
./proxy/hdrs/HdrToken.h
./proxy/hdrs/test_header.cc
./proxy/hdrs/HttpCompat.h
./proxy/sac.cc
./proxy/ProxyClientTransaction.cc
./tools/http_load/timers.c
./tools/http_load/timers.h
./tools/http_load/http_load.c
./tools/http_load/port.h
./tools/lighttpd_mod_generator/mod_generator.c
./tools/jtest/jtest.cc
+ git diff --exit-code
diff --git a/proxy/hdrs/URL.cc b/proxy/hdrs/URL.cc
index 0aff2c1..bc3851d 100644
--- a/proxy/hdrs/URL.cc
+++ b/proxy/hdrs/URL.cc
@@ -1817,7 +1817,6 @@ REGRESSION_TEST(VALIDATE_HDR_FIELD)(RegressionTest *t, int /* level ATS_UNUSED *
   }
 }
 
-
 REGRESSION_TEST(ParseRules_strict_URI)(RegressionTest *t, int /* level ATS_UNUSED */, int *pstatus)
 {
   const struct {
diff --git a/proxy/hdrs/URL.h b/proxy/hdrs/URL.h
index a68edca..ef4db3a 100644
--- a/proxy/hdrs/URL.h
+++ b/proxy/hdrs/URL.h
@@ -236,7 +236,8 @@ void url_params_set(HdrHeap *heap, URLImpl *url, const char *value, int length,
 void url_query_set(HdrHeap *heap, URLImpl *url, const char *value, int length, bool copy_string);
 void url_fragment_set(HdrHeap *heap, URLImpl *url, const char *value, int length, bool copy_string);
 
-MIMEParseResult url_parse(HdrHeap *heap, URLImpl *url, const char **start, const char *end, bool copy_strings, bool strict_uri_parsing = false);
+MIMEParseResult url_parse(HdrHeap *heap, URLImpl *url, const char **start, const char *end, bool copy_strings,
+                          bool strict_uri_parsing = false);
 MIMEParseResult url_parse_no_path_component_breakdown(HdrHeap *heap, URLImpl *url, const char **start, const char *end,
                                                       bool copy_strings);
 MIMEParseResult url_parse_internet(HdrHeap *heap, URLImpl *url, const char **start, const char *end, bool copy_strings);
diff --git a/proxy/http/HttpConfig.h b/proxy/http/HttpConfig.h
index e43796e..824ea7c 100644
--- a/proxy/http/HttpConfig.h
+++ b/proxy/http/HttpConfig.h
@@ -858,11 +858,11 @@ inline HttpConfigParams::HttpConfigParams()
     parent_connect_attempts(4), per_parent_connect_attempts(2), parent_connect_timeout(30), anonymize_other_header_list(NULL),
     enable_http_stats(1), icp_enabled(0), stale_icp_enabled(0), cache_vary_default_text(NULL), cache_vary_default_images(NULL),
     cache_vary_default_other(NULL), cache_enable_default_vary_headers(0), cache_post_method(0), connect_ports_string(NULL),
-    connect_ports(NULL), push_method_enabled(0), referer_filter_enabled(0), referer_format_redirect(0), strict_uri_parsing(0), reverse_proxy_enabled(0),
-    url_remap_required(1), record_cop_page(0), errors_log_error_pages(1), enable_http_info(0), cluster_time_delta(0),
-    redirection_host_no_port(1), post_copy_size(2048), ignore_accept_mismatch(0), ignore_accept_language_mismatch(0),
-    ignore_accept_encoding_mismatch(0), ignore_accept_charset_mismatch(0), send_100_continue_response(0),
-    disallow_post_100_continue(0), parser_allow_non_http(1), max_post_size(0),
+    connect_ports(NULL), push_method_enabled(0), referer_filter_enabled(0), referer_format_redirect(0), strict_uri_parsing(0),
+    reverse_proxy_enabled(0), url_remap_required(1), record_cop_page(0), errors_log_error_pages(1), enable_http_info(0),
+    cluster_time_delta(0), redirection_host_no_port(1), post_copy_size(2048), ignore_accept_mismatch(0),
+    ignore_accept_language_mismatch(0), ignore_accept_encoding_mismatch(0), ignore_accept_charset_mismatch(0),
+    send_100_continue_response(0), disallow_post_100_continue(0), parser_allow_non_http(1), max_post_size(0),
     server_session_sharing_pool(TS_SERVER_SESSION_SHARING_POOL_THREAD), synthetic_port(0)
 {
 }
Build step 'Execute shell' marked build as failure