You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "jin xing (JIRA)" <ji...@apache.org> on 2019/07/24 07:46:00 UTC

[jira] [Updated] (CALCITE-3209) Store inputs of MutableMultiRel by ArrayList rather than ImmutableList

     [ https://issues.apache.org/jira/browse/CALCITE-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jin xing updated CALCITE-3209:
------------------------------
    Description: 
When digging code of materialization matching. I found the current implementation of {{MutableMultiRel::}}{{inputs}} is by an {{ImmutableList}}, thus impossible to be changed by
 [https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/mutable/MutableMultiRel.java#L42]
{code:java}
 @Override public void setInput(int ordinalInParent, MutableRel input)
{code}
Seems a mistake.

  was:
In current implementation of {{MutableMultiRel}}, {{inputs}} is implemented by a {{ImmutableList}}, thus impossible to be changed by
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/mutable/MutableMultiRel.java#L42
{code:java}
 @Override public void setInput(int ordinalInParent, MutableRel input)
{code}
Seems a mistake.


> Store inputs of MutableMultiRel by ArrayList rather than ImmutableList
> ----------------------------------------------------------------------
>
>                 Key: CALCITE-3209
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3209
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: jin xing
>            Priority: Major
>
> When digging code of materialization matching. I found the current implementation of {{MutableMultiRel::}}{{inputs}} is by an {{ImmutableList}}, thus impossible to be changed by
>  [https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/mutable/MutableMultiRel.java#L42]
> {code:java}
>  @Override public void setInput(int ordinalInParent, MutableRel input)
> {code}
> Seems a mistake.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)