You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rekhajoshm <gi...@git.apache.org> on 2016/05/24 18:44:06 UTC
[GitHub] flink pull request: [FLINK-2771] Fix for IterateTest.testSimpleIte...
GitHub user rekhajoshm opened a pull request:
https://github.com/apache/flink/pull/2028
[FLINK-2771] Fix for IterateTest.testSimpleIteration fail on Travis
[FLINK-2771] Fix for IterateTest.testSimpleIteration fail on Travis
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rekhajoshm/flink FLINK-2771
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2028.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2028
----
commit d7df832c17592d840d1419e4b6bc1764664c2e75
Author: Joshi <re...@gmail.com>
Date: 2016-05-24T18:46:40Z
[FLINK-2771] Fix for IterateTest.testSimpleIteration fail on Travis
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2771] Fix for IterateTest.testSimpleIte...
Posted by rekhajoshm <gi...@git.apache.org>.
Github user rekhajoshm commented on the pull request:
https://github.com/apache/flink/pull/2028#issuecomment-222197851
Yes, glad to @StephanEwen . Looking forward to your design for timeout-based termination to a proper "end-of-stream-event" based termination. thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2028: [FLINK-2771] Fix for IterateTest.testSimpleIterati...
Posted by rekhajoshm <gi...@git.apache.org>.
Github user rekhajoshm closed the pull request at:
https://github.com/apache/flink/pull/2028
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2028: [FLINK-2771] Fix for IterateTest.testSimpleIteration fail...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2028
I think the proper solution to this is outside of the scope of this PR. This hasn't occurred in a long time. I will change the timeout to the suggested 5000 ms and merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2028: [FLINK-2771] Fix for IterateTest.testSimpleIteration fail...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2028
Turns out the test has been removed in the mean time. Could you please close this PR @rekhajoshm?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2028: [FLINK-2771] Fix for IterateTest.testSimpleIteration fail...
Posted by rekhajoshm <gi...@git.apache.org>.
Github user rekhajoshm commented on the issue:
https://github.com/apache/flink/pull/2028
done @uce
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2771] Fix for IterateTest.testSimpleIte...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/2028#issuecomment-221853220
Thanks for looking into this.
Making the iteration timeout longer makes the test more stable, but still not absolutely stable. It also increases the time that the build takes, for every build.
I think a good start would be to increase the timeout to 5000 (a bit more stability), and then actually improve the test and the iterations themselves:
- The test case could be modified to actually run the program with a large iteration timeout. But the program is started in a separate thread, and the main thread checks for the result periodically (every 50ms or so) and cancels the program as soon as the expected result is there. That way, the test will return fast if the execution is fast, and will still be pretty reliable, because the termination has a long timeout.
- We should change the stream iteration behavior from a timeout-based termination to a proper "end-of-stream-event" based termination. That would also automatically make the test reliable and predictable. This is a bit more involved, but would be the best solution. I'd be happy to write more about that in a design doc, if you want to do that.
Please let us know if you would be up for helping out with these efforts!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---