You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Newton Alex <na...@pivotal.io> on 2015/09/24 03:12:01 UTC
Review Request 38703: AMBARI-13156 - Display HAWQ General Section in
HAWQ config screen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38703/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-13156
https://issues.apache.org/jira/browse/AMBARI-13156
Repository: ambari
Description
-------
Display HAWQ General Section in HAWQ config screen along with substituted hostname values
Diffs
-----
ambari-web/app/data/HDP2.3/site_properties.js 10390ac
ambari-web/app/models/stack_service.js 5ba528a
ambari-web/app/utils/configs/config_property_helper.js 9b528dd
Diff: https://reviews.apache.org/r/38703/diff/
Testing
-------
6761 tests complete (16 seconds)
94 tests pending
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .idea/**
[INFO] Exclude: package.json
[INFO] Exclude: public/**
[INFO] Exclude: public-static/**
[INFO] Exclude: app/assets/**
[INFO] Exclude: vendor/**
[INFO] Exclude: node_modules/**
[INFO] Exclude: node/**
[INFO] Exclude: npm-debug.log
[INFO] 1207 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1207 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33.238 s
[INFO] Finished at: 2015-09-23T17:58:27-08:00
[INFO] Final Memory: 10M/308M
[INFO] ------------------------------------------------------------------------
Thanks,
Newton Alex
Re: Review Request 38703: AMBARI-13156 - Display HAWQ General Section
in HAWQ config screen
Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38703/#review101522
-----------------------------------------------------------
Ship it!
Ship It!
- Oleksandr Diachenko
On Sept. 24, 2015, 1:12 a.m., Newton Alex wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38703/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 1:12 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13156
> https://issues.apache.org/jira/browse/AMBARI-13156
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Display HAWQ General Section in HAWQ config screen along with substituted hostname values
>
>
> Diffs
> -----
>
> ambari-web/app/data/HDP2.3/site_properties.js 10390ac
> ambari-web/app/models/stack_service.js 5ba528a
> ambari-web/app/utils/configs/config_property_helper.js 9b528dd
>
> Diff: https://reviews.apache.org/r/38703/diff/
>
>
> Testing
> -------
>
> 6761 tests complete (16 seconds)
> 94 tests pending
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .idea/**
> [INFO] Exclude: package.json
> [INFO] Exclude: public/**
> [INFO] Exclude: public-static/**
> [INFO] Exclude: app/assets/**
> [INFO] Exclude: vendor/**
> [INFO] Exclude: node_modules/**
> [INFO] Exclude: node/**
> [INFO] Exclude: npm-debug.log
> [INFO] 1207 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1207 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33.238 s
> [INFO] Finished at: 2015-09-23T17:58:27-08:00
> [INFO] Final Memory: 10M/308M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Newton Alex
>
>
Re: Review Request 38703: AMBARI-13156 - Display HAWQ General Section
in HAWQ config screen
Posted by Newton Alex <na...@pivotal.io>.
> On Sept. 30, 2015, 8:56 p.m., jun aoki wrote:
> > ambari-web/app/data/HDP2.3/site_properties.js, line 579
> > <https://reviews.apache.org/r/38703/diff/1/?file=1083690#file1083690line579>
> >
> > Not knowing too much how this collaborate with the helper below, but hawqmaster_host and hawqstandby_host are missing from here. Is it a problem?
>
> Newton Alex wrote:
> The hawq_master_address_host is the actual hawqmaster_host (the display name should be saying HAWQ Master). The site_property.js contains the exact name as in the config file(in this case hawq-site.xml)
>
> jun aoki wrote:
> Then why do we need hawqmaster_host and hawqstandby_host in line 349 of config_property_helper.js? sorry Lack of my knowledge, I dont get where hawqmaster_host and hawqstandby_host are set but shows up in the helper.
I put them in so that we can access the hawqmaster_host and hawqstandby_host like any other hosts (for example: hbasemaster_host, hivemetastore_host) and don't have to remember the exact variable name like hawq_master_address_host.
This is a stub for the follow up tickets like adding widgets to the HAWQ config UI.
- Newton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38703/#review101151
-----------------------------------------------------------
On Sept. 24, 2015, 1:12 a.m., Newton Alex wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38703/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 1:12 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13156
> https://issues.apache.org/jira/browse/AMBARI-13156
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Display HAWQ General Section in HAWQ config screen along with substituted hostname values
>
>
> Diffs
> -----
>
> ambari-web/app/data/HDP2.3/site_properties.js 10390ac
> ambari-web/app/models/stack_service.js 5ba528a
> ambari-web/app/utils/configs/config_property_helper.js 9b528dd
>
> Diff: https://reviews.apache.org/r/38703/diff/
>
>
> Testing
> -------
>
> 6761 tests complete (16 seconds)
> 94 tests pending
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .idea/**
> [INFO] Exclude: package.json
> [INFO] Exclude: public/**
> [INFO] Exclude: public-static/**
> [INFO] Exclude: app/assets/**
> [INFO] Exclude: vendor/**
> [INFO] Exclude: node_modules/**
> [INFO] Exclude: node/**
> [INFO] Exclude: npm-debug.log
> [INFO] 1207 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1207 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33.238 s
> [INFO] Finished at: 2015-09-23T17:58:27-08:00
> [INFO] Final Memory: 10M/308M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Newton Alex
>
>
Re: Review Request 38703: AMBARI-13156 - Display HAWQ General Section
in HAWQ config screen
Posted by Newton Alex <na...@pivotal.io>.
> On Sept. 30, 2015, 8:56 p.m., jun aoki wrote:
> > ambari-web/app/data/HDP2.3/site_properties.js, line 579
> > <https://reviews.apache.org/r/38703/diff/1/?file=1083690#file1083690line579>
> >
> > Not knowing too much how this collaborate with the helper below, but hawqmaster_host and hawqstandby_host are missing from here. Is it a problem?
The hawq_master_address_host is the actual hawqmaster_host (the display name should be saying HAWQ Master). The site_property.js contains the exact name as in the config file(in this case hawq-site.xml)
- Newton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38703/#review101151
-----------------------------------------------------------
On Sept. 24, 2015, 1:12 a.m., Newton Alex wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38703/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 1:12 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13156
> https://issues.apache.org/jira/browse/AMBARI-13156
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Display HAWQ General Section in HAWQ config screen along with substituted hostname values
>
>
> Diffs
> -----
>
> ambari-web/app/data/HDP2.3/site_properties.js 10390ac
> ambari-web/app/models/stack_service.js 5ba528a
> ambari-web/app/utils/configs/config_property_helper.js 9b528dd
>
> Diff: https://reviews.apache.org/r/38703/diff/
>
>
> Testing
> -------
>
> 6761 tests complete (16 seconds)
> 94 tests pending
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .idea/**
> [INFO] Exclude: package.json
> [INFO] Exclude: public/**
> [INFO] Exclude: public-static/**
> [INFO] Exclude: app/assets/**
> [INFO] Exclude: vendor/**
> [INFO] Exclude: node_modules/**
> [INFO] Exclude: node/**
> [INFO] Exclude: npm-debug.log
> [INFO] 1207 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1207 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33.238 s
> [INFO] Finished at: 2015-09-23T17:58:27-08:00
> [INFO] Final Memory: 10M/308M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Newton Alex
>
>
Re: Review Request 38703: AMBARI-13156 - Display HAWQ General Section
in HAWQ config screen
Posted by jun aoki <ju...@gmail.com>.
> On Sept. 30, 2015, 8:56 p.m., jun aoki wrote:
> > ambari-web/app/data/HDP2.3/site_properties.js, line 579
> > <https://reviews.apache.org/r/38703/diff/1/?file=1083690#file1083690line579>
> >
> > Not knowing too much how this collaborate with the helper below, but hawqmaster_host and hawqstandby_host are missing from here. Is it a problem?
>
> Newton Alex wrote:
> The hawq_master_address_host is the actual hawqmaster_host (the display name should be saying HAWQ Master). The site_property.js contains the exact name as in the config file(in this case hawq-site.xml)
Then why do we need hawqmaster_host and hawqstandby_host in line 349 of config_property_helper.js? sorry Lack of my knowledge, I dont get where hawqmaster_host and hawqstandby_host are set but shows up in the helper.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38703/#review101151
-----------------------------------------------------------
On Sept. 24, 2015, 1:12 a.m., Newton Alex wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38703/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 1:12 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13156
> https://issues.apache.org/jira/browse/AMBARI-13156
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Display HAWQ General Section in HAWQ config screen along with substituted hostname values
>
>
> Diffs
> -----
>
> ambari-web/app/data/HDP2.3/site_properties.js 10390ac
> ambari-web/app/models/stack_service.js 5ba528a
> ambari-web/app/utils/configs/config_property_helper.js 9b528dd
>
> Diff: https://reviews.apache.org/r/38703/diff/
>
>
> Testing
> -------
>
> 6761 tests complete (16 seconds)
> 94 tests pending
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .idea/**
> [INFO] Exclude: package.json
> [INFO] Exclude: public/**
> [INFO] Exclude: public-static/**
> [INFO] Exclude: app/assets/**
> [INFO] Exclude: vendor/**
> [INFO] Exclude: node_modules/**
> [INFO] Exclude: node/**
> [INFO] Exclude: npm-debug.log
> [INFO] 1207 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1207 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33.238 s
> [INFO] Finished at: 2015-09-23T17:58:27-08:00
> [INFO] Final Memory: 10M/308M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Newton Alex
>
>
Re: Review Request 38703: AMBARI-13156 - Display HAWQ General Section
in HAWQ config screen
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38703/#review101151
-----------------------------------------------------------
ambari-web/app/data/HDP2.3/site_properties.js (line 579)
<https://reviews.apache.org/r/38703/#comment158500>
Not knowing too much how this collaborate with the helper below, but hawqmaster_host and hawqstandby_host are missing from here. Is it a problem?
- jun aoki
On Sept. 24, 2015, 1:12 a.m., Newton Alex wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38703/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 1:12 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13156
> https://issues.apache.org/jira/browse/AMBARI-13156
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Display HAWQ General Section in HAWQ config screen along with substituted hostname values
>
>
> Diffs
> -----
>
> ambari-web/app/data/HDP2.3/site_properties.js 10390ac
> ambari-web/app/models/stack_service.js 5ba528a
> ambari-web/app/utils/configs/config_property_helper.js 9b528dd
>
> Diff: https://reviews.apache.org/r/38703/diff/
>
>
> Testing
> -------
>
> 6761 tests complete (16 seconds)
> 94 tests pending
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .idea/**
> [INFO] Exclude: package.json
> [INFO] Exclude: public/**
> [INFO] Exclude: public-static/**
> [INFO] Exclude: app/assets/**
> [INFO] Exclude: vendor/**
> [INFO] Exclude: node_modules/**
> [INFO] Exclude: node/**
> [INFO] Exclude: npm-debug.log
> [INFO] 1207 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1207 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33.238 s
> [INFO] Finished at: 2015-09-23T17:58:27-08:00
> [INFO] Final Memory: 10M/308M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Newton Alex
>
>
Re: Review Request 38703: AMBARI-13156 - Display HAWQ General Section
in HAWQ config screen
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38703/#review102117
-----------------------------------------------------------
Ship it!
Great that we're adding HAWQ! please include me in future code reviews.
- Alejandro Fernandez
On Oct. 9, 2015, 9:27 p.m., Newton Alex wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38703/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 9:27 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13156
> https://issues.apache.org/jira/browse/AMBARI-13156
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Display HAWQ General Section in HAWQ config screen along with substituted hostname values
>
>
> Diffs
> -----
>
> ambari-web/app/data/HDP2.3/site_properties.js 12d1b9a
> ambari-web/app/models/stack_service.js 7300ae7
> ambari-web/app/utils/configs/config_property_helper.js 11f1d81
>
> Diff: https://reviews.apache.org/r/38703/diff/
>
>
> Testing
> -------
>
> 6761 tests complete (16 seconds)
> 94 tests pending
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .idea/**
> [INFO] Exclude: package.json
> [INFO] Exclude: public/**
> [INFO] Exclude: public-static/**
> [INFO] Exclude: app/assets/**
> [INFO] Exclude: vendor/**
> [INFO] Exclude: node_modules/**
> [INFO] Exclude: node/**
> [INFO] Exclude: npm-debug.log
> [INFO] 1207 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1207 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33.238 s
> [INFO] Finished at: 2015-09-23T17:58:27-08:00
> [INFO] Final Memory: 10M/308M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Newton Alex
>
>
Re: Review Request 38703: AMBARI-13156 - Display HAWQ General Section
in HAWQ config screen
Posted by Newton Alex <na...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38703/
-----------------------------------------------------------
(Updated Oct. 9, 2015, 9:27 p.m.)
Review request for Ambari.
Bugs: AMBARI-13156
https://issues.apache.org/jira/browse/AMBARI-13156
Repository: ambari
Description
-------
Display HAWQ General Section in HAWQ config screen along with substituted hostname values
Diffs (updated)
-----
ambari-web/app/data/HDP2.3/site_properties.js 12d1b9a
ambari-web/app/models/stack_service.js 7300ae7
ambari-web/app/utils/configs/config_property_helper.js 11f1d81
Diff: https://reviews.apache.org/r/38703/diff/
Testing
-------
6761 tests complete (16 seconds)
94 tests pending
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .idea/**
[INFO] Exclude: package.json
[INFO] Exclude: public/**
[INFO] Exclude: public-static/**
[INFO] Exclude: app/assets/**
[INFO] Exclude: vendor/**
[INFO] Exclude: node_modules/**
[INFO] Exclude: node/**
[INFO] Exclude: npm-debug.log
[INFO] 1207 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1207 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33.238 s
[INFO] Finished at: 2015-09-23T17:58:27-08:00
[INFO] Final Memory: 10M/308M
[INFO] ------------------------------------------------------------------------
Thanks,
Newton Alex