[GitHub] wuyoushan commented on issue #1754: receive zipkin spans error

[GitBox <gi...@apache.org>]

wuyoushan commented on issue #1754: receive zipkin spans error
URL: https://github.com/apache/incubator-skywalking/issues/1754#issuecomment-455983905
 
 
   I debugged the program. In line 107 parentId ="2d10f39070f84afe" List<Span> spanList 
   
   0={"traceId":"2d10f39070f84afe","parentId":"2d10f39070f84afe","id":"b490d6fce6c33284","kind":"SERVER"}
   1={"traceId":"2d10f39070f84afe","parentId":"2d10f39070f84afe","id":"7ad683dff428ad15","kind":"CLIENT"}
   2={"traceId":"2d10f39070f84afe","parentId":"2d10f39070f84afe","id":"b490d6fce6c33284","kind":"CLIENT"}
   3={"traceId":"2d10f39070f84afe","parentId":"2d10f39070f84afe","id":"7ad683dff428ad15","kind":"SERVER"}
   
   List has order, if the span order is changed to kind=CLIENT in front
   0={"traceId":"2d10f39070f84afe","parentId":"2d10f39070f84afe","id":"7ad683dff428ad15","kind":"CLIENT"}
   1={"traceId":"2d10f39070f84afe","parentId":"2d10f39070f84afe","id":"b490d6fce6c33284","kind":"CLIENT"}
   2={"traceId":"2d10f39070f84afe","parentId":"2d10f39070f84afe","id":"b490d6fce6c33284","kind":"SERVER"}
   3={"traceId":"2d10f39070f84afe","parentId":"2d10f39070f84afe","id":"7ad683dff428ad15","kind":"SERVER"}
   
   clientPartSpan will add the corresponding object on line 162, so 238 lines will not produce NPE
   
   I want to create a merge request to modify it, but I don't know how to modify it.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services