[PR] arch/x86_64:Configure arch delay using CONFIG_ALARM_ARCH [nuttx]

["xianglyc (via GitHub)" <gi...@apache.org>]

xianglyc opened a new pull request, #13993:
URL: https://github.com/apache/nuttx/pull/13993

   ## Summary
   Configure arch delay using CONFIG_ALARM_ARCH
   ## Impact
   no impact
   ## Testing
   ostest
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/x86_64:Configure arch delay using CONFIG_ALARM_ARCH [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #13993:
URL: https://github.com/apache/nuttx/pull/13993#issuecomment-2402083983

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **No, this PR does not meet the NuttX requirements.**
   
   **Missing Information:**
   
   * **Detailed explanation of the change:**  
       * **Why** is this change necessary? Is there a bug, performance issue, or a need for a new feature?
       * **What** exactly does `CONFIG_ALARM_ARCH` do? 
       * **How** does configuring it impact the system?
   * **Specific testing details:**
       * **Build Host:**  Provide details about your build environment (OS, CPU, compiler version).
       * **Target(s):** Specify the architectures and boards you tested on.
       * **Testing logs:**  "ostest" is not sufficient. Include relevant log snippets demonstrating the issue before the change and the improvement after the change.
   
   **Recommendations:**
   
   1. **Expand the Summary:** Provide a clear and concise explanation of the problem this PR solves or the enhancement it introduces.
   2. **Elaborate on the Impact:** Even if there is no user-facing impact, explain why. For example, "This change is internal to the alarm driver and does not affect the public API."
   3. **Provide Specific Testing Details:**  Include the required details about your build and target environments, along with relevant log excerpts. 
   
   **Example for Improved Testing Section:**
   
   ```
   ## Testing
   
   I confirm that changes are verified on my local setup and work as intended:
   
   * **Build Host:** Ubuntu 20.04, Intel Core i7, GCC 9.4.0
   * **Target(s):**
       * `sim:nsh`
       * `stm32f4discovery:nsh` 
   
   **Testing logs before change:**
   
   ```
   (Logs showing the incorrect or inefficient behavior before the change)
   ```
   
   **Testing logs after change:**
   
   ```
   (Logs demonstrating the corrected or improved behavior)
   ```
   ``` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/x86_64:Configure arch delay using CONFIG_ALARM_ARCH [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #13993:
URL: https://github.com/apache/nuttx/pull/13993


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org