You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by le...@apache.org on 2009/09/12 13:01:29 UTC

svn commit: r814142 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java

Author: lektran
Date: Sat Sep 12 11:01:29 2009
New Revision: 814142

URL: http://svn.apache.org/viewvc?rev=814142&view=rev
Log:
Some more incorrect object comparisons

Modified:
    ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java

Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java?rev=814142&r1=814141&r2=814142&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java Sat Sep 12 11:01:29 2009
@@ -1372,7 +1372,7 @@
                 }
             }
 
-            if (quantityDesired == startingQuantity || quantityDesired.compareTo(BigDecimal.ZERO) > 0) {
+            if (quantityDesired.compareTo(startingQuantity) == 0 || quantityDesired.compareTo(BigDecimal.ZERO) > 0) {
                 // couldn't find any (or enough) cart items to give a discount to, don't consider action run
                 actionResultInfo.ranAction = false;
                 // clear out any action uses for this so they don't become part of anything else
@@ -1418,7 +1418,7 @@
                 }
             }
 
-            if (quantityDesired == startingQuantity) {
+            if (quantityDesired.compareTo(startingQuantity) == 0) {
                 // couldn't find any cart items to give a discount to, don't consider action run
                 actionResultInfo.ranAction = false;
             } else {