You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/18 22:39:35 UTC
[GitHub] [lucene-solr] anshumg opened a new pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format
anshumg opened a new pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649
This may still not be ideal/acceptable but allows for having internal version numbers in the `x.y.z.a` format instead of `x.y.z-a` format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on a change in pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#discussion_r830460575
##########
File path: lucene/common-build.xml
##########
@@ -63,7 +63,7 @@
<fail message="If you pass -Dversion=... to set a release version, it must match "${version.base}", optionally followed by a suffix (e.g., "-SNAPSHOT").">
<condition>
- <not><matches pattern="^\Q${version.base}\E(|\-.*)$" casesensitive="true" string="${version}"/></not>
+ <not><matches pattern="^\Q${version.base}\E(|.*)$" casesensitive="true" string="${version}"/></not>
</condition>
Review comment:
At least there must be a `\b` (boundary) instead of the dash. The current change would match a version like 1.2.34 as valid for 1.2.3 base version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on a change in pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#discussion_r830460575
##########
File path: lucene/common-build.xml
##########
@@ -63,7 +63,7 @@
<fail message="If you pass -Dversion=... to set a release version, it must match "${version.base}", optionally followed by a suffix (e.g., "-SNAPSHOT").">
<condition>
- <not><matches pattern="^\Q${version.base}\E(|\-.*)$" casesensitive="true" string="${version}"/></not>
+ <not><matches pattern="^\Q${version.base}\E(|.*)$" casesensitive="true" string="${version}"/></not>
</condition>
Review comment:
At least there must be a `\b` (boundary) instead of the dash. This would match a version like 1.2.34 as valid for 1.2.3 base version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] anshumg commented on pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format
Posted by GitBox <gi...@apache.org>.
anshumg commented on pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1074345569
Thanks for your suggestion @uschindler. I like your suggestion but can't think of a clean way to make this work for multiple internal releases. I'm trying to avoid forking anything while also keeping that version formatting that's numeric. Perhaps there's a way to work with the naming and switch the semantics in such use cases.
Not going to merge this in until I'm convinced there's no other way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1072980556
I am not sure about the consequences for scripts, but this variant should be fine. The spec version inside jar files stays with version base so the compatibility is ensured.
I still don't understand why somebody doing a fork or custom build needs to have a dot. Lucene says "appendix with dash", so downstream users should respect this. If you create a custom jdk you also have to use their very strict versioning patterns (e.g adoptopenjdk, Coretto). They also require plain base version numbers and strings like Coretto or bugfix versions must match main branch.
If one makes an incompatible fork, Maven coordinates should be adapted.
This is just my personal view on it, others may see it different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on a change in pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#discussion_r830460575
##########
File path: lucene/common-build.xml
##########
@@ -63,7 +63,7 @@
<fail message="If you pass -Dversion=... to set a release version, it must match "${version.base}", optionally followed by a suffix (e.g., "-SNAPSHOT").">
<condition>
- <not><matches pattern="^\Q${version.base}\E(|\-.*)$" casesensitive="true" string="${version}"/></not>
+ <not><matches pattern="^\Q${version.base}\E(|.*)$" casesensitive="true" string="${version}"/></not>
</condition>
Review comment:
At least there must be a `\b` (boundary) instead of the dash. This would match a version like 1.2.34 as valid for q.w.e base version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] anshumg commented on pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format
Posted by GitBox <gi...@apache.org>.
anshumg commented on pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1072869336
My concern here is for people who have scripts assuming the presence of `-` automatically. This might break back-compat for those folks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler edited a comment on pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format
Posted by GitBox <gi...@apache.org>.
uschindler edited a comment on pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1072980556
I am not sure about the consequences for scripts, but this variant should be fine. The spec version inside jar files stays with version base so the compatibility is ensured.
I still don't understand why somebody doing a fork or custom build needs to have a dot. Lucene says "appendix with dash", so downstream users should respect this. If you create a custom jdk you also have to use their very strict versioning patterns (e.g adoptopenjdk, Coretto). They also require plain base version numbers and strings like Coretto or bugfix versions must match be in implementation appendixes clearly specified.
If one makes an incompatible fork, Maven coordinates should be adapted.
This is just my personal view on it, others may see it different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org