You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/02 02:40:16 UTC

[GitHub] [ozone] ChenSammi commented on pull request #2290: HDDS-5268. Ensure disk checker also scans the ratis log disks periodically

ChenSammi commented on pull request #2290:
URL: https://github.com/apache/ozone/pull/2290#issuecomment-852668780


   Thanks @guihecheng for working on this.   Two general comments, 
   1.  The config "hdds.datanode.failed.volumes.tolerated" takes failed metadata volumes into consideration.  I would suggest use seperate properties to control the metadata volumes and data volumes. 
   2. Would it be more clear that using different MutableVolumeSet to hold the data volume set and meta volume set? 
   
   Please also do consider if the current abstration is enough if rocksdbs are combined into one instance and saved on a different disk than current data disk in future. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org