You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dave Brosius (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2012/03/01 17:24:01 UTC

[jira] [Issue Comment Edited] (CASSANDRA-3986) Cli shouldn't call FBU.getBroadcastAddress needlessly

    [ https://issues.apache.org/jira/browse/CASSANDRA-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220131#comment-13220131 ] 

Dave Brosius edited comment on CASSANDRA-3986 at 3/1/12 4:23 PM:
-----------------------------------------------------------------

+1

Getting user reports that this is causing cli on windows to fail due to not being able to load the yaml for some reason (when creating keyspaces)
                
      was (Author: dbrosius@apache.org):
    Getting user reports that this is causing cli on windows to fail due to not being able to load the yaml for some reason (when creating keyspaces)
                  
> Cli shouldn't call FBU.getBroadcastAddress needlessly
> -----------------------------------------------------
>
>                 Key: CASSANDRA-3986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3986
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.8
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 1.0.9, 1.1.0
>
>         Attachments: 3986.txt
>
>
> The cli is calling this, which causes yaml to be loaded, but the broadcast address isn't needed.
> {code}
>             // adding default data center from SimpleSnitch
>             if (currentStrategyOptions == null || currentStrategyOptions.isEmpty())
>             {
>                 SimpleSnitch snitch = new SimpleSnitch();
>                 Map<String, String> options = new HashMap<String, String>();
>                 options.put(snitch.getDatacenter(FBUtilities.getBroadcastAddress()), "1");
>                 ksDef.setStrategy_options(options);
>             }
> {code}
> because SimpleSnitch always returns 'datacenter1'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira