You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/28 10:58:26 UTC

[GitHub] [arrow-datafusion] metesynnada commented on a diff in pull request #3570: Custom window frame logic (support `ROWS`, `RANGE`, `PRECEDING` and `FOLLOWING` for window functions)

metesynnada commented on code in PR #3570:
URL: https://github.com/apache/arrow-datafusion/pull/3570#discussion_r982256211


##########
datafusion/physical-expr/src/aggregate/sum.rs:
##########
@@ -511,28 +374,6 @@ mod tests {
 
     #[test]
     fn sum_decimal() -> Result<()> {
-        // test sum

Review Comment:
   Since we alter the summation operation and added the subtraction operation inside the `ScalarValue` implementation, we moved the relevant tests under the `scalar.rs`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org