You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by hu...@apache.org on 2019/06/24 03:46:32 UTC

[helix.wiki] branch master updated: Created Pull Request Guidelines (markdown)

This is an automated email from the ASF dual-hosted git repository.

hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.wiki.git


The following commit(s) were added to refs/heads/master by this push:
     new 3e47b6b  Created Pull Request Guidelines (markdown)
3e47b6b is described below

commit 3e47b6b8ca90eaae66a65d2b82d0fb9cb0a9537f
Author: Hunter Lee <na...@gmail.com>
AuthorDate: Sun Jun 23 20:46:31 2019 -0700

    Created Pull Request Guidelines (markdown)
---
 Pull-Request-Guidelines.md | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Pull-Request-Guidelines.md b/Pull-Request-Guidelines.md
new file mode 100644
index 0000000..d3da6b1
--- /dev/null
+++ b/Pull-Request-Guidelines.md
@@ -0,0 +1,9 @@
+# Pull Request Guidelines
+Before you submit a pull request from your forked repo, check that it meets these guidelines:
+
+* The pull request should include tests, either as unit tests, integration tests, or both. 
+* The pull request should include the result of "mvn test" command.
+* Please [rebase your fork](https://stackoverflow.com/questions/7244321/how-do-i-update-a-github-forked-repository/7244456#7244456), squash commits, and resolve all conflicts.
+* Every pull request should have an associated issue. The issue must be linked in the PR description.
+* Add an [Apache License header](http://www.apache.org/legal/src-headers.html) to all new files
+* If the pull request adds functionality, please add a corresponding wiki page detailing the motivation and use of the feature.
\ No newline at end of file