You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/04/20 07:41:15 UTC

[GitHub] [thrift] pspeter commented on a diff in pull request #2565: Fix bug in Python's THttpClient proxy handling

pspeter commented on code in PR #2565:
URL: https://github.com/apache/thrift/pull/2565#discussion_r853824427


##########
lib/py/src/transport/THttpClient.py:
##########
@@ -100,7 +100,7 @@ def basic_proxy_auth_header(proxy):
         ap = "%s:%s" % (urllib.parse.unquote(proxy.username),
                         urllib.parse.unquote(proxy.password))
         cr = base64.b64encode(ap.encode()).strip()
-        return "Basic " + cr
+        return "Basic " + cr.decode()

Review Comment:
   Ah, that makes sense. I'll see if I can make this work using `six`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org