You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@liminal.apache.org by GitBox <gi...@apache.org> on 2021/04/08 14:44:55 UTC

[GitHub] [incubator-liminal] naturalett commented on a change in pull request #35: add local deploy flag

naturalett commented on a change in pull request #35:
URL: https://github.com/apache/incubator-liminal/pull/35#discussion_r609779607



##########
File path: scripts/liminal
##########
@@ -131,10 +131,6 @@ def deploy_liminal_apps(path, clean):
         yml_name = os.path.basename(config_file)
         target_yml_name = os.path.join(environment.get_dags_dir(), yml_name)
         shutil.copyfile(config_file, target_yml_name)
-        with open(config_file) as stream:

Review comment:
       What do you mean? Here we don't load kube_config.
   It takes place it liminal create.
   And it won't fail in liminal create.
   I cover it with try..catch




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org