You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/06/16 03:02:23 UTC

[jira] Created: (HDFS-1207) 0.20-append: stallReplicationWork should be volatile

0.20-append: stallReplicationWork should be volatile
----------------------------------------------------

                 Key: HDFS-1207
                 URL: https://issues.apache.org/jira/browse/HDFS-1207
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: name-node
    Affects Versions: 0.20-append
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon


the stallReplicationWork member in FSNamesystem is accessed by multiple threads without synchronization, but isn't marked volatile. I believe this is responsible for about 1% failure rate on TestFileAppend4.testAppendSyncChecksum* on my 8-core test boxes (looking at logs I see replication happening even though we've supposedly disabled it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HDFS-1207) 0.20-append: stallReplicationWork should be volatile

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur resolved HDFS-1207.
------------------------------------

    Fix Version/s: 0.20-append
       Resolution: Fixed

I just committed this. Thanks Todd!

> 0.20-append: stallReplicationWork should be volatile
> ----------------------------------------------------
>
>                 Key: HDFS-1207
>                 URL: https://issues.apache.org/jira/browse/HDFS-1207
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.20-append
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.20-append
>
>         Attachments: hdfs-1207.txt
>
>
> the stallReplicationWork member in FSNamesystem is accessed by multiple threads without synchronization, but isn't marked volatile. I believe this is responsible for about 1% failure rate on TestFileAppend4.testAppendSyncChecksum* on my 8-core test boxes (looking at logs I see replication happening even though we've supposedly disabled it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.