You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2026/05/05 19:10:04 UTC
[PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
thisisnic opened a new pull request, #49929:
URL: https://github.com/apache/arrow/pull/49929
### Rationale for this change
We don't need to support R 4.1 as a new version is out
### What changes are included in this PR?
Bump minimum supported version to 4.2
### Are these changes tested?
In CI, sure
### Are there any user-facing changes?
Nope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4387777773
Are those two crossbow failures on main too? Do we have issues for them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4389204705
@github-actions crossbow submit test-r-arrow-backwards-compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #49929:
URL: https://github.com/apache/arrow/pull/49929#discussion_r3196418183
##########
.github/workflows/r.yml:
##########
@@ -284,14 +284,13 @@ jobs:
- name: Download Timezone Database
shell: bash
run: |
- # RTools 40 uses GCC 8.x which does not support C++20 chrono timezones,
- # so Arrow uses the vendored date library which requires tzdata
+ # Download tzdata in case the vendored date library is used for timezones
Review Comment:
I updated the comment to be clearer now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4389196756
The `test-r-arrow-backwards-compatibility` failure is because there are no binaries available from P3M for those Arrow versions and so we build from source with no Arrow C++ libraries and get failures. Given those versions of Arrow are ancient now, I'll remove the CI job like we did with the older ones in https://github.com/apache/arrow/pull/46294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #49929:
URL: https://github.com/apache/arrow/pull/49929#discussion_r3195281017
##########
.github/workflows/r.yml:
##########
@@ -284,14 +284,13 @@ jobs:
- name: Download Timezone Database
shell: bash
run: |
- # RTools 40 uses GCC 8.x which does not support C++20 chrono timezones,
- # so Arrow uses the vendored date library which requires tzdata
+ # Download tzdata in case the vendored date library is used for timezones
Review Comment:
@amoeba would know more than I do, but I think we still need to workaround the tz file issue, but we now do that with an R package instead of the C++ program thing here. Or am I confused about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #49929:
URL: https://github.com/apache/arrow/pull/49929#discussion_r3190929953
##########
dev/tasks/macros.jinja:
##########
@@ -277,8 +277,6 @@ env:
{# use filter to cast to string and convert to lowercase to match yaml boolean #}
{% set is_fork = (not is_upstream_b)|lower %}
-{% set r_release = {"ver": "4.2", "rt" : "42"} %}
-{% set r_oldrel = {"ver": "4.1", "rt" : "40"} %}
Review Comment:
These variables are never used anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4387989589
> Are those two crossbow failures on main too? Do we have issues for them?
Yes, they've been failing on the nightlies for ~a week. See:
https://s3.amazonaws.com/arrow-data/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4555126806
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4565477724
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d9bc3b947cb94fee783c2261d4090d1ed3dcf050.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/78322402622) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4389340168
The ticket for `mac-os-as-cran` is https://github.com/apache/arrow/issues/49941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4389554186
Is the R / AMD64 Windows C++ RTools 42 ucrt64 failure on main too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4382254806
Revision: 682fe0aa8077906235dffd0f6276bc167e1af097
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8480702cfb](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8480702cfb)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/25396910694/job/74486013484)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/25396912615/job/74486019867)|
|test-r-alpine-linux-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/25396911005/job/74486014310)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/25396910927/job/74486013973)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/25396909934/job/74486012095)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/25396911956/job/74486017194)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/25396911955/job/74486017333)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/25396909790/job/74486012004)|
|test-r-fedora-clang|[](https://github.com/ursacomputing/crossbow/actions/runs/25396910040/job/74486012247)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/25396911052/job/74486014509)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/25396912465/job/74486019275)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/25396911516/job/74486015449)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/25396911088/job/74486014668)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/25396912494/job/74486019395)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/25396912031/job/74486017235)|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/25396910067/job/74486012460)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/25396911906/job/74486017304)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/25396912430/job/74486018837)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/25396910638/job/74486013214)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/25396911902/job/74486016888)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/25396910866/job/74486013856)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/25396911347/job/74486015506)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4382235475
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #49929:
URL: https://github.com/apache/arrow/pull/49929#discussion_r3311228582
##########
dev/tasks/r/github.linux.arrow.version.back.compat.yml:
##########
@@ -90,10 +90,8 @@ jobs:
- { old_arrow_version: '10.0.1', r: '4.2' }
- { old_arrow_version: '9.0.0', r: '4.2' }
- { old_arrow_version: '8.0.0', r: '4.2' }
- - { old_arrow_version: '7.0.0', r: '4.1' }
- - { old_arrow_version: '6.0.1', r: '4.1' }
- - { old_arrow_version: '5.0.0', r: '4.1' }
- - { old_arrow_version: '4.0.0', r: '4.1' }
+ - { old_arrow_version: '7.0.0', r: '4.2' }
+ - { old_arrow_version: '6.0.1', r: '4.2' }
Review Comment:
The back-compat matrix no longer includes any Arrow versions < 6.0.0 (e.g., 5.0.0/4.0.0 were dropped), which makes the `Prepare RSPM` step’s `if [ ${old_arrow_version_major} -ge 6 ] ... else ...` branch effectively always take the `>= 6` path. Either re-add the intended <6 entries (if you still want coverage there) or simplify the workflow by removing the now-dead `< 6` handling to avoid confusing future maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4389223497
Revision: ce6d92987766ec76a118c6f9460623dcebe9ca1b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-756eb23241](https://github.com/ursacomputing/crossbow/branches/all?query=actions-756eb23241)
|Task|Status|
|----|------|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/25442431496/job/74637097638)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4391102925
> Is the R / AMD64 Windows C++ RTools 42 ucrt64 failure on main too?
Nope, good spot, this is the one I'm trying to fix with the CA certificate shenanigans that RTools42 dislikes. Will iterate to see if I can sort it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #49929:
URL: https://github.com/apache/arrow/pull/49929#discussion_r3197266546
##########
.github/workflows/r.yml:
##########
@@ -284,14 +284,13 @@ jobs:
- name: Download Timezone Database
shell: bash
run: |
- # RTools 40 uses GCC 8.x which does not support C++20 chrono timezones,
- # so Arrow uses the vendored date library which requires tzdata
+ # Download tzdata in case the vendored date library is used for timezones
Review Comment:
I think we can remove this, but a separate PR is fine. We still need to use this script in other CI jobs where R isn't involved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #49929:
URL: https://github.com/apache/arrow/pull/49929#discussion_r3197434033
##########
ci/scripts/r_windows_build.sh:
##########
@@ -23,6 +23,18 @@ set -ex
# Make sure it is absolute and exported
export ARROW_HOME="$(cd "${ARROW_HOME}" && pwd)"
+# Ensure CA certificates are available for pacman (Rtools42+ may not bundle them)
+if [ ! -f /usr/ssl/certs/ca-bundle.crt ]; then
+ mkdir -p /usr/ssl/certs
+ for src in /c/rtools45/usr/ssl/certs/ca-bundle.crt \
+ "/c/Program Files/Git/mingw64/etc/ssl/certs/ca-bundle.crt"; do
+ if [ -f "$src" ]; then
+ cp "$src" /usr/ssl/certs/ca-bundle.crt
+ break
+ fi
+ done
+fi
Review Comment:
Thanks for checking, will push some changes which print paths etc to see more of what's happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4518886114
> The ticket for test-r-macos-as-cran is https://github.com/apache/arrow/issues/49941
Oops, sorry I didn't dig into this as much as I should have. This is actually resolved by: #50020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49929:
URL: https://github.com/apache/arrow/pull/49929#issuecomment-4555151346
Revision: ef2c014df90c960e109de0beaebb8ba14a0f365c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7437589700](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7437589700)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/26515412888/job/78091207158)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/26515413700/job/78091054482)|
|test-r-alpine-linux-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/26515416071/job/78091062750)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/26515413471/job/78091054052)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/26515411708/job/78091045969)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/26515412470/job/78091049060)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/26515414334/job/78091057043)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/26515414686/job/78091057555)|
|test-r-fedora-clang|[](https://github.com/ursacomputing/crossbow/actions/runs/26515415433/job/78091059791)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/26515415140/job/78091058345)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/26515412940/job/78091051220)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/26515415224/job/78091058981)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/26515412768/job/78091050376)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/26515413303/job/78091052659)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/26515413184/job/78091051406)|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/26515412288/job/78091048154)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/26515412551/job/78091049661)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/26515412832/job/78091051778)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/26515414531/job/78091057556)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/26515414253/job/78091057174)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/26515413596/job/78091053808)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/26515412683/job/78091049988)|
|test-r-wasm|[](https://github.com/ursacomputing/crossbow/actions/runs/26515413383/job/78091053034)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #49929:
URL: https://github.com/apache/arrow/pull/49929#discussion_r3197148062
##########
ci/scripts/r_windows_build.sh:
##########
@@ -23,6 +23,18 @@ set -ex
# Make sure it is absolute and exported
export ARROW_HOME="$(cd "${ARROW_HOME}" && pwd)"
+# Ensure CA certificates are available for pacman (Rtools42+ may not bundle them)
+if [ ! -f /usr/ssl/certs/ca-bundle.crt ]; then
+ mkdir -p /usr/ssl/certs
+ for src in /c/rtools45/usr/ssl/certs/ca-bundle.crt \
+ "/c/Program Files/Git/mingw64/etc/ssl/certs/ca-bundle.crt"; do
+ if [ -f "$src" ]; then
+ cp "$src" /usr/ssl/certs/ca-bundle.crt
+ break
+ fi
+ done
+fi
Review Comment:
Rtools42 definitely bundles these so something else must be going on. I just checked by installing Rtools42 and `/usr/ssl/certs` is all set up and pacman works fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #49929:
URL: https://github.com/apache/arrow/pull/49929#discussion_r3191704611
##########
ci/scripts/r_windows_build.sh:
##########
@@ -23,6 +23,18 @@ set -ex
# Make sure it is absolute and exported
export ARROW_HOME="$(cd "${ARROW_HOME}" && pwd)"
+# Ensure CA certificates are available for pacman (Rtools42+ may not bundle them)
+if [ ! -f /usr/ssl/certs/ca-bundle.crt ]; then
+ mkdir -p /usr/ssl/certs
+ for src in /c/rtools45/usr/ssl/certs/ca-bundle.crt \
+ "/c/Program Files/Git/mingw64/etc/ssl/certs/ca-bundle.crt"; do
+ if [ -f "$src" ]; then
+ cp "$src" /usr/ssl/certs/ca-bundle.crt
+ break
+ fi
+ done
+fi
Review Comment:
Claude addition as job fails if we don't do this - unsure if best approach but looks like a CI-specific failure and will see if it makes the CI pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #49929:
URL: https://github.com/apache/arrow/pull/49929#discussion_r3190928495
##########
.github/workflows/r.yml:
##########
@@ -284,14 +284,13 @@ jobs:
- name: Download Timezone Database
shell: bash
run: |
- # RTools 40 uses GCC 8.x which does not support C++20 chrono timezones,
- # so Arrow uses the vendored date library which requires tzdata
+ # Download tzdata in case the vendored date library is used for timezones
Review Comment:
Does the RTools bump and associated GCC version increase means that this is no longer needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #49929:
URL: https://github.com/apache/arrow/pull/49929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org