[GitHub] [couchdb-jiffy] wohali commented on pull request #4: Refactor build scripts to remove binary blobs

[GitBox <gi...@apache.org>]

wohali commented on pull request #4:
URL: https://github.com/apache/couchdb-jiffy/pull/4#issuecomment-853414332


   Hey @noahshaw11 , thanks for the PR, but I'm going to close it. Here's why:
   
   1. This is just the Apache fork of https://github.com/davisp/jiffy , so the PR should land there instead.
   2. Unfortunately, this isn't cross-platform compatible. We require a build process that functions under Microsoft Windows without the use of a UNIX-like build environment. That means no shell scripts (or, at least, Windows-equivalent PowerShell scripts.)
   
   For reference, CouchDB builds `rebar` (v2) at the top level itself - and doesn't use the included binary in this repo. You can see how we do this in a platform-neutral fashion here:
   
   https://github.com/apache/couchdb/blob/main/configure#L257-L266
   https://github.com/apache/couchdb/blob/main/configure.ps1#L190-L202
   
   Hopefully this gives you a leg up. We'd certainly accept a PR to https://github.com/apache/couchdb/ that builds `enc` at the top level as well, though there has been some discussion of moving to `rebar3` or `mix` entirely. I hope with this info, you are able to refactor this in a different fashion (over on Paul's repo). We can then pull a new version downstream into CouchDB.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org