You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2012/07/28 02:31:34 UTC
[jira] [Created] (HADOOP-8630) rename isSingleSwitch() methods in
new topo base class to isFlatTopology()
Steve Loughran created HADOOP-8630:
--------------------------------------
Summary: rename isSingleSwitch() methods in new topo base class to isFlatTopology()
Key: HADOOP-8630
URL: https://issues.apache.org/jira/browse/HADOOP-8630
Project: Hadoop Common
Issue Type: Improvement
Components: util
Affects Versions: 2.0.0-alpha, 3.0.0
Reporter: Steve Loughran
Priority: Trivial
The new topology logic that is not yet turned on in HDFS uses the method {{isSingleSwitch()}} for implementations to declare whether or not they are single switch.
The use of "switch" is an implementation issue; the big VM-based patch shows that really it's about "flat" vs "hierarchical", with Hadoop assuming that subtrees in the hierarchy have better bandwidth (good) but correlated failures (bad).
Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8630) rename isSingleSwitch() methods in
new topo base class to isFlatTopology()
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426753#comment-13426753 ]
Steve Loughran commented on HADOOP-8630:
----------------------------------------
# that patch does a complete file replace; looks like CRLF grief, which I've encountered myself regularly.
# can you grab the github fork I linked to and use that as a starting point as I did a bit more changes, including renaming the (new) base class. It needs more review and a test run, but I think it's effectively a superset of your patch.
-steve
> rename isSingleSwitch() methods in new topo base class to isFlatTopology()
> --------------------------------------------------------------------------
>
> Key: HADOOP-8630
> URL: https://issues.apache.org/jira/browse/HADOOP-8630
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Steve Loughran
> Priority: Trivial
> Attachments: HADOOP-8630.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The new topology logic that is not yet turned on in HDFS uses the method {{isSingleSwitch()}} for implementations to declare whether or not they are single switch.
> The use of "switch" is an implementation issue; the big VM-based patch shows that really it's about "flat" vs "hierarchical", with Hadoop assuming that subtrees in the hierarchy have better bandwidth (good) but correlated failures (bad).
> Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8630) rename isSingleSwitch() methods in
new topo base class to isFlatTopology()
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428414#comment-13428414 ]
Steve Loughran commented on HADOOP-8630:
----------------------------------------
patch + a pull is best. Note that that specific branch on github includes a place in DFS where it's actually used -that bit isn't part of the patch for common; two patches need to be created from the source tree
> rename isSingleSwitch() methods in new topo base class to isFlatTopology()
> --------------------------------------------------------------------------
>
> Key: HADOOP-8630
> URL: https://issues.apache.org/jira/browse/HADOOP-8630
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Steve Loughran
> Priority: Trivial
> Attachments: HADOOP-8630.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The new topology logic that is not yet turned on in HDFS uses the method {{isSingleSwitch()}} for implementations to declare whether or not they are single switch.
> The use of "switch" is an implementation issue; the big VM-based patch shows that really it's about "flat" vs "hierarchical", with Hadoop assuming that subtrees in the hierarchy have better bandwidth (good) but correlated failures (bad).
> Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8630) rename isSingleSwitch() methods in
new topo base class to isFlatTopology()
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425033#comment-13425033 ]
Steve Loughran commented on HADOOP-8630:
----------------------------------------
renaming classes would break things. This method is new in 2.x and we can do it, especially as I haven't flipped the namenode into using it.
Compatibility beats purity
> rename isSingleSwitch() methods in new topo base class to isFlatTopology()
> --------------------------------------------------------------------------
>
> Key: HADOOP-8630
> URL: https://issues.apache.org/jira/browse/HADOOP-8630
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Steve Loughran
> Priority: Trivial
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The new topology logic that is not yet turned on in HDFS uses the method {{isSingleSwitch()}} for implementations to declare whether or not they are single switch.
> The use of "switch" is an implementation issue; the big VM-based patch shows that really it's about "flat" vs "hierarchical", with Hadoop assuming that subtrees in the hierarchy have better bandwidth (good) but correlated failures (bad).
> Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8630) rename isSingleSwitch() methods in
new topo base class to isFlatTopology()
Posted by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428207#comment-13428207 ]
Tsuyoshi OZAWA commented on HADOOP-8630:
----------------------------------------
Steve,
Thank you for you review. Okey, I'll fix it.
Should I send a pull request to your repository or attach the patch to this jira?
> rename isSingleSwitch() methods in new topo base class to isFlatTopology()
> --------------------------------------------------------------------------
>
> Key: HADOOP-8630
> URL: https://issues.apache.org/jira/browse/HADOOP-8630
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Steve Loughran
> Priority: Trivial
> Attachments: HADOOP-8630.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The new topology logic that is not yet turned on in HDFS uses the method {{isSingleSwitch()}} for implementations to declare whether or not they are single switch.
> The use of "switch" is an implementation issue; the big VM-based patch shows that really it's about "flat" vs "hierarchical", with Hadoop assuming that subtrees in the hierarchy have better bandwidth (good) but correlated failures (bad).
> Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8630) rename isSingleSwitch() methods in
new topo base class to isFlatTopology()
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425106#comment-13425106 ]
Steve Loughran commented on HADOOP-8630:
----------------------------------------
current code is in https://github.com/steveloughran/hadoop-trunk/tree/HDFS-2492-blocks
> rename isSingleSwitch() methods in new topo base class to isFlatTopology()
> --------------------------------------------------------------------------
>
> Key: HADOOP-8630
> URL: https://issues.apache.org/jira/browse/HADOOP-8630
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Steve Loughran
> Priority: Trivial
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The new topology logic that is not yet turned on in HDFS uses the method {{isSingleSwitch()}} for implementations to declare whether or not they are single switch.
> The use of "switch" is an implementation issue; the big VM-based patch shows that really it's about "flat" vs "hierarchical", with Hadoop assuming that subtrees in the hierarchy have better bandwidth (good) but correlated failures (bad).
> Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8630) rename isSingleSwitch() methods in
new topo base class to isFlatTopology()
Posted by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424734#comment-13424734 ]
Tsuyoshi OZAWA commented on HADOOP-8630:
----------------------------------------
There are some files and methods which include the term"Switch"(AbstractDNSToSwitchMapping.java, CachedDNSToSwitchMapping.java, DNSToSwitchMapping.java). Should these files and methods be renamed with the term "Hierarchicy"(ex. AbstractDNSToHierarchyMapping.java)?
> rename isSingleSwitch() methods in new topo base class to isFlatTopology()
> --------------------------------------------------------------------------
>
> Key: HADOOP-8630
> URL: https://issues.apache.org/jira/browse/HADOOP-8630
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Steve Loughran
> Priority: Trivial
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The new topology logic that is not yet turned on in HDFS uses the method {{isSingleSwitch()}} for implementations to declare whether or not they are single switch.
> The use of "switch" is an implementation issue; the big VM-based patch shows that really it's about "flat" vs "hierarchical", with Hadoop assuming that subtrees in the hierarchy have better bandwidth (good) but correlated failures (bad).
> Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8630) rename isSingleSwitch() methods in
new topo base class to isFlatTopology()
Posted by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsuyoshi OZAWA updated HADOOP-8630:
-----------------------------------
Attachment: HADOOP-8630.patch
Renamed AbstractDNSToSwitchMapping to AbstractTopologyMapping and isSingleSwitch() to isFlatTopology() by the attached patch.
> rename isSingleSwitch() methods in new topo base class to isFlatTopology()
> --------------------------------------------------------------------------
>
> Key: HADOOP-8630
> URL: https://issues.apache.org/jira/browse/HADOOP-8630
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Steve Loughran
> Priority: Trivial
> Attachments: HADOOP-8630.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The new topology logic that is not yet turned on in HDFS uses the method {{isSingleSwitch()}} for implementations to declare whether or not they are single switch.
> The use of "switch" is an implementation issue; the big VM-based patch shows that really it's about "flat" vs "hierarchical", with Hadoop assuming that subtrees in the hierarchy have better bandwidth (good) but correlated failures (bad).
> Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8630) rename isSingleSwitch() methods in
new topo base class to isFlatTopology()
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425098#comment-13425098 ]
Steve Loughran commented on HADOOP-8630:
----------------------------------------
Looking at the code, what I can do is rename the new base class in the 2.x branch to {{AbstractTopologyMapping}}, and the methods and documents in it.
> rename isSingleSwitch() methods in new topo base class to isFlatTopology()
> --------------------------------------------------------------------------
>
> Key: HADOOP-8630
> URL: https://issues.apache.org/jira/browse/HADOOP-8630
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Steve Loughran
> Priority: Trivial
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The new topology logic that is not yet turned on in HDFS uses the method {{isSingleSwitch()}} for implementations to declare whether or not they are single switch.
> The use of "switch" is an implementation issue; the big VM-based patch shows that really it's about "flat" vs "hierarchical", with Hadoop assuming that subtrees in the hierarchy have better bandwidth (good) but correlated failures (bad).
> Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8630) rename isSingleSwitch() methods in
new topo base class to isFlatTopology()
Posted by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsuyoshi OZAWA updated HADOOP-8630:
-----------------------------------
Attachment: HADOOP-8630.2.patch
Attached patch is the patch based on trunk by using git format-patch command. And, I sent pull request based on your github.
> rename isSingleSwitch() methods in new topo base class to isFlatTopology()
> --------------------------------------------------------------------------
>
> Key: HADOOP-8630
> URL: https://issues.apache.org/jira/browse/HADOOP-8630
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Steve Loughran
> Priority: Trivial
> Attachments: HADOOP-8630.2.patch, HADOOP-8630.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The new topology logic that is not yet turned on in HDFS uses the method {{isSingleSwitch()}} for implementations to declare whether or not they are single switch.
> The use of "switch" is an implementation issue; the big VM-based patch shows that really it's about "flat" vs "hierarchical", with Hadoop assuming that subtrees in the hierarchy have better bandwidth (good) but correlated failures (bad).
> Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira