[GitHub] [maven-release] bguerin commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles

[GitBox <gi...@apache.org>]

bguerin commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506185320



##########
File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##########
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest performRequest, ReleaseResult result
             ReleaseUtils.buildReleaseDescriptor( performRequest.getReleaseDescriptorBuilder() )
             .getActivateProfiles();
 
-        ReleaseDescriptor releaseDescriptor =
-            loadReleaseDescriptor( performRequest.getReleaseDescriptorBuilder(),
-                                   performRequest.getReleaseManagerListener() );
+        ReleaseDescriptorBuilder builder =
+            loadReleaseDescriptorBuilder( performRequest.getReleaseDescriptorBuilder(),
+                                          performRequest.getReleaseManagerListener() );
 
         if ( specificProfiles != null && !specificProfiles.isEmpty() )
         {
+            List<String> allProfiles = new ArrayList<>();

Review comment:
       once again ... this PR fix my previous one, where a Unit Test WAS ADDED
   
   https://github.com/apache/maven-release/pull/50/files#diff-c4d606c66477b937977eccf603f2f04a7b87f464b7439bcb8e4576307792ff2cR709
   
   and this PR changes a little bit this test




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org