You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by zi...@apache.org on 2022/07/28 01:57:24 UTC

[dolphinscheduler] branch dev updated: [Improvement][ExecutorServiceImpl] remove some unnecessary (#11122)

This is an automated email from the ASF dual-hosted git repository.

zihaoxiang pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new 81fa09678c [Improvement][ExecutorServiceImpl] remove some unnecessary (#11122)
81fa09678c is described below

commit 81fa09678c201250312ef5acb5874227c9b3ce97
Author: fuchanghai <33...@users.noreply.github.com>
AuthorDate: Thu Jul 28 09:57:19 2022 +0800

    [Improvement][ExecutorServiceImpl] remove some unnecessary (#11122)
---
 .../api/service/impl/ExecutorServiceImpl.java                 | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java
index a414891d63..63ebc69536 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java
@@ -800,10 +800,7 @@ public class ExecutorServiceImpl extends BaseServiceImpl implements ExecutorServ
                     createCount = listDate.size();
                     if (!CollectionUtils.isEmpty(listDate)) {
                         if (expectedParallelismNumber != null && expectedParallelismNumber != 0) {
-                            createCount = Math.min(listDate.size(), expectedParallelismNumber);
-                            if (listDateSize < createCount) {
-                                createCount = listDateSize;
-                            }
+                            createCount = Math.min(createCount, expectedParallelismNumber);
                         }
                         logger.info("In parallel mode, current expectedParallelismNumber:{}", createCount);
 
@@ -843,14 +840,10 @@ public class ExecutorServiceImpl extends BaseServiceImpl implements ExecutorServ
                 }
                 if (StringUtils.isNotEmpty(dateList)) {
                     List<String> listDate = Arrays.asList(dateList.split(COMMA));
-                    int listDateSize = listDate.size();
                     createCount = listDate.size();
                     if (!CollectionUtils.isEmpty(listDate)) {
                         if (expectedParallelismNumber != null && expectedParallelismNumber != 0) {
-                            createCount = Math.min(listDate.size(), expectedParallelismNumber);
-                            if (listDateSize < createCount) {
-                                createCount = listDateSize;
-                            }
+                            createCount = Math.min(createCount, expectedParallelismNumber);
                         }
                         logger.info("In parallel mode, current expectedParallelismNumber:{}", createCount);
                         for (List<String> stringDate : Lists.partition(listDate, createCount)) {