You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub)" <gi...@apache.org> on 2024/01/11 10:09:07 UTC
[PR] MINOR: Disalow using a group id with only whitespaces in the new consumer group protocol [kafka]
dajac opened a new pull request, #15173:
URL: https://github.com/apache/kafka/pull/15173
This patch strengthen the validation of the group id when the new consumer group protocol is used.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Disalow using a group id with only whitespaces in the new consumer group protocol [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #15173:
URL: https://github.com/apache/kafka/pull/15173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Disalow using a group id with only whitespaces in the new consumer group protocol [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #15173:
URL: https://github.com/apache/kafka/pull/15173#issuecomment-1887118525
Perhaps we need a ConfigValidator whcih says NullOrNonEmptyString. We could have used that validator here. https://github.com/apache/kafka/blob/dba789dc93d8dee2965ea41df49f0c981f5dfa6f/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java#L398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Disalow using a group id with only whitespaces in the new consumer group protocol [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #15173:
URL: https://github.com/apache/kafka/pull/15173#issuecomment-1887121573
Indeed, null is valid. Empty string is also valid but deprecated. Here I only want to ensure that we don't use it with the new protocol now. We strengthen the validation on the client in 4.0 to prevent using an empty string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org